The default bug view has changed. See this FAQ.

GetBounds on bullet return wrong values

RESOLVED FIXED in mozilla15

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: surkov, Assigned: surkov)

Tracking

(Blocks: 2 bugs, {access})

unspecified
mozilla15
access
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 623470 [details] [diff] [review]
patch
Attachment #623470 - Flags: review?(trev.saunders)
Attachment #623470 - Flags: review?(roc)
(Assignee)

Comment 1

5 years ago
Comment on attachment 623470 [details] [diff] [review]
patch

Review of attachment 623470 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/generic/nsBlockFrame.h
@@ +784,5 @@
>     * @return the outside bullet frame list frame property.
>     */
>    nsFrameList* GetOutsideBulletList() const;
>  
> +protected:

I removed that locally
(Assignee)

Updated

5 years ago
Summary: GetBounds on frame return wrong values → GetBounds on bullet return wrong values
Comment on attachment 623470 [details] [diff] [review]
patch

>+HTMLListBulletAccessible::GetFrame() const
>+{
>+  nsBlockFrame* blockFrame = do_QueryFrame(mContent->GetPrimaryFrame());
>+  if (blockFrame)
>+    return blockFrame->GetBullet();

shouldn't you return null if this isn't true?

>+<body>
>+
>+  <p id="display"></p>
>+  <div id="content" style="display: none"></div>
>+  <pre id="test">
>+  </pre>

shouldn't there be a bug reference?

r=me with those
Attachment #623470 - Flags: review?(trev.saunders) → review+
Attachment #623470 - Flags: review?(roc) → review+
(Assignee)

Comment 3

5 years ago
landed with Trevor's comments addressed - https://hg.mozilla.org/integration/mozilla-inbound/rev/cf84757bce4b
Flags: in-testsuite+
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/cf84757bce4b
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.