Last Comment Bug 754627 - GetBounds on bullet return wrong values
: GetBounds on bullet return wrong values
Status: RESOLVED FIXED
: access
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla15
Assigned To: alexander :surkov
:
Mentors:
Depends on:
Blocks: bulleta11y 659589
  Show dependency treegraph
 
Reported: 2012-05-12 19:45 PDT by alexander :surkov
Modified: 2012-05-14 14:12 PDT (History)
3 users (show)
surkov.alexander: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (9.98 KB, patch)
2012-05-12 19:45 PDT, alexander :surkov
tbsaunde+mozbugs: review+
roc: review+
Details | Diff | Splinter Review

Description alexander :surkov 2012-05-12 19:45:51 PDT
Created attachment 623470 [details] [diff] [review]
patch
Comment 1 alexander :surkov 2012-05-12 19:48:26 PDT
Comment on attachment 623470 [details] [diff] [review]
patch

Review of attachment 623470 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/generic/nsBlockFrame.h
@@ +784,5 @@
>     * @return the outside bullet frame list frame property.
>     */
>    nsFrameList* GetOutsideBulletList() const;
>  
> +protected:

I removed that locally
Comment 2 Trevor Saunders (:tbsaunde) 2012-05-13 08:13:24 PDT
Comment on attachment 623470 [details] [diff] [review]
patch

>+HTMLListBulletAccessible::GetFrame() const
>+{
>+  nsBlockFrame* blockFrame = do_QueryFrame(mContent->GetPrimaryFrame());
>+  if (blockFrame)
>+    return blockFrame->GetBullet();

shouldn't you return null if this isn't true?

>+<body>
>+
>+  <p id="display"></p>
>+  <div id="content" style="display: none"></div>
>+  <pre id="test">
>+  </pre>

shouldn't there be a bug reference?

r=me with those
Comment 3 alexander :surkov 2012-05-13 21:51:01 PDT
landed with Trevor's comments addressed - https://hg.mozilla.org/integration/mozilla-inbound/rev/cf84757bce4b
Comment 4 Matt Brubeck (:mbrubeck) 2012-05-14 14:12:11 PDT
https://hg.mozilla.org/mozilla-central/rev/cf84757bce4b

Note You need to log in before you can comment on or make changes to this bug.