75498 - PlainText reply puts everything on one line

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect)

Description

[Mike Pinkerton (not reading bugmail)]

- make plain text compose your default for mail compose
- reply to an email

notice everything in the quoted mail is on one line. the signature is joined
together on a separate line.

makes it pretty darn hard to reply to any email.

Comment 1

[scottputterman]

Does this happen on all of your mail or just some particular messages?  Is this
with a build that you pulled later in the day on 4/10 or something that's been
happening all day.

I'm using 2001041004 on Win 2000 and I'm not noticing any problems.  I don't
have a Mac handy to try to repro on that.

Comment 2

[Jean-Francois Ducarroz]

I can reproduce this problem on Mac. However it works fine on Windows. Can somebody tests this on Linux?

Comment 3

[Simon Fraser [no longer active]]

This is probably a line breaks issue, if it differs between platforms.

Comment 4

[Akkana Peck]

On linux, plaintext replies look fine, line breaks as usual.

Joe or Mike, could this be caused by the same string API problems that caused
the multiline paste bug?

Comment 5

[Jean-Francois Ducarroz]

seems to be ralated to my fix for bug 74901.

Comment 6

[Jean-Francois Ducarroz]

HTML replies are fine.

Comment 7

[Jean-Francois Ducarroz]

The problem already appears on build from 04/09/2000 04:00.

Comment 8

[Johnny Stenback (:jst)]

Is this a regression caused by the fix for bug 58377? Could someone try backing
that change out to see if this problem is fixed?

Comment 9

[Simon Fraser [no longer active]]

I think this is a regression from ducarroz removing linebreak conversions in mail 
compose. The deal is that editor does its own conversions for HTML inserts, but 
not plain text. Patch coming...

Comment 10

[Simon Fraser [no longer active]]

Actually, I don't have a patch. There are too many different entry points where 
clients can insert plain text in the editor. Ducarroz, I think you should back 
out your change.

Comment 11

[Jean-Francois Ducarroz]

I am currently testing a patch on Windows. My Mac still building today tree...

Comment 12

[kinmoz]

Just wanted to add that I don't see this bug on Win32 with my debug build from 
today, so it seems to be mac only.

Comment 13

[Jean-Francois Ducarroz]

Attachment: proposed fix

Comment 14

[Mike Pinkerton (not reading bugmail)]

don't we already have code that translates line endings (nsLinebreakHelpers, or 
something)?

Comment 15

[Simon Fraser [no longer active]]

That patch would be fine, but for the fact that nsString::GetUnicode returns a 
const PRUnichar* (i.e. you are not allowed to write into it). However, nsString 
does expose mUStr via nsStr, so you could use that.

Pink: yes we do, but it doesn't work on nsAutoStrings (because I suck).

Comment 16

[Jean-Francois Ducarroz]

Anyway, this is a temporary fix. The real fix should be in editor! I Presume
editor replace LF by <BR> when inserting data in plain text mode but miss case
when they is only CRs! If nobody has an objection, I'll check this patch in...10
minutes

Comment 17

[Jean-Francois Ducarroz]

Attachment: Second proposed fix. Include remarks from sfraser

Comment 18

[Simon Fraser [no longer active]]

r=sfraser

Comment 19

[Scott MacGregor]

sr=mscott

Comment 20

[Jean-Francois Ducarroz]

Fixed and checked in.

Comment 21

[Jean-Francois Ducarroz]

I have filed bug 75618 for the real problem in editor.

Comment 22

[Koike Kazuhiko]

I'm seeing the opposite problem on Win32 build.
Please take a look at bug 67391.

Comment 23

[Joe Francis]

It's also possible that this is related to a regression caused by the xpidl 
editor landing.  If I fnd that is the case then we may be able to undo this fix.

Comment 24

[Sheela Ravindran]

marking verified- reply from html and plain compose window works well now. 
Infact I did not see extraline added to the quoted text on win98 in the below 
mentioned build.
win98-2001-04-16-06
mac-2001-04-16-04
linux-2001-04-15-21