75618 - CR line breaks not recognized when inserting data in a plain text editor

Status: NEW

(Core :: DOM: Editor, defect, P5)

Description

[Jean-Francois Ducarroz]

Since we stop converting line ending to LF in msgCompose.cpp (see bug 74901), we
are not able to reply to a message on Mac in plain text mode. I have checked in
a temporary fix for that (see bug 75498) but we need to fix this problem inside
editor.

Looks like that the code that convert line ending to <BR> looks only for LF!

Comment 1

[Akkana Peck]

Long ago, I wrote code for the editor to accept any kind of newline.  Joe
flagged it and pointed out that it would create a big performance hit everywhere
that text was ever inserted, because of the newline translation we have to do. 
I think he timed it both ways.  The editor team discussed it and eventually we
decided to accept only DOM newlines for performance reasons.

Add this to the long list of "problems that would go away if layout would let us
have frames on blank lines".

Comment 2

[Simon Fraser [no longer active]]

-> joe

Comment 3

[Joe Francis]

moz 0.9 - fix in hand

Comment 4

[Joe Francis]

fix checked in

Comment 5

[sujay]

ducarroz, is this working for you now ?

Comment 6

[Jean-Francois Ducarroz]

Let me do some testing...

Comment 7

[Jean-Francois Ducarroz]

Nope, it still doesn't work. If I undo the fix for bug 75498 which was the
workaround, then the original problem, bug 74901, is back! Sorry, reopen...

Comment 8

[Jon Granrose]

SPAM: mozilla 0.9 (and M1, and 0.8.1, etc.) has left the building.  please
update the target milestone so we can get a good idea of what's left for 0.9.1.

Comment 9

[rubydoo123]

moving to 9.2

Comment 10

[Asa Dotzler [:asa]]

Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 
(you can query for this string to delete spam or retrieve the list of bugs I've 
moved)

Comment 11

[Joe Francis]

The days of having a half dozen milestones out in front of us to divide bugs 
between seem to be gone, though I dont know why.  Lumping everything together as 
far out as I can.  I'll pull back things that I am working on as I go.

Comment 12

[Joe Francis]

[ushing these out as far as bugzilla will let me.  I'll pull them back as I work
on them.

Comment 13

[Frankie]

Mach-O uses LF instead of CR, right?

Comment 14

[Jens Stutte [:jstutte]]

Bulk-downgrade of unassigned, >=3 years untouched DOM/Storage bug's priority.

If you have reason to believe this is wrong, please write a comment and ni :jstutte.

Comment 15

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

In bug 1478564, I stopped TextEditor receiving text containing \r.
https://searchfox.org/mozilla-central/rev/7426a35738cd542b9488c7b67f4f6d21edfeda0a/editor/libeditor/TextEditSubActionHandler.cpp#296

However, I don't see sanitation in HTMLEditor.
https://searchfox.org/mozilla-central/rev/7426a35738cd542b9488c7b67f4f6d21edfeda0a/editor/libeditor/HTMLEditorDataTransfer.cpp#1931

So I guess this is still valid... (Although there is no platform using solo \r as a linebreak.)