Closed Bug 754993 Opened 13 years ago Closed 13 years ago

Disable default Dropbox support from Filelink

Categories

(Thunderbird :: General, defect)

Product:
Thunderbird
Component:
General
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird13 fixed, thunderbird14+ fixed, thunderbird15+ fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 13.0
Tracking Flags:
Tracking Status
thunderbird13 --- fixed
thunderbird14 + fixed
thunderbird15 + fixed

People

(Reporter: mconley, Assigned: mconley)

References

Details

Attachments

(2 files)

Patch v1
669 bytes, patch
Bienvenu
: review+
Bienvenu
: approval-comm-aurora+
Bienvenu
: approval-comm-beta+
Details | Diff | Splinter Review
Disable Dropbox tests
9.89 KB, patch
Bienvenu
: review+
Bienvenu
: approval-comm-aurora+
Bienvenu
: approval-comm-beta+
Details | Diff | Splinter Review
Our Dropbox support is not ready, and will not be shipped for TB 13. We will be disabling it until further notice.
tracking-thunderbird13: --- → ?
OS: Mac OS X → All
Attached patch Patch v1 — — Splinter Review
Attachment #623795 - Flags: review?(dbienvenu)
Comment on attachment 623795 [details] [diff] [review] Patch v1 luckily, cloudFileAccounts.js getProviderForType has a try catch so existing accounts that are no longer valid won't mess up the rest of the accounts.
Attachment #623795 - Flags: review?(dbienvenu) → review+
Comment on attachment 623795 [details] [diff] [review] Patch v1 I know we want this in beta... but do we want this across the board? Aurora and Daily too?
Attachment #623795 - Flags: approval-comm-beta?
Comment on attachment 623795 [details] [diff] [review] Patch v1 I think we can hold off on aurora for a bit.
Attachment #623795 - Flags: approval-comm-beta? → approval-comm-beta+
comm-beta: https://hg.mozilla.org/releases/comm-beta/rev/279def847fd6
Status: NEW → RESOLVED
Closed: 13 years ago
status-thunderbird13: --- → fixed
tracking-thunderbird13: ? → ---
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 13.0
Whoops - I forgot to wipe out the Dropbox tests as well, which are going to fail hard on beta because the component is now missing.
Attachment #624058 - Flags: review?(dbienvenu)
Attachment #624058 - Flags: approval-comm-beta?
Comment on attachment 624058 [details] [diff] [review] Disable Dropbox tests d'oh, oops!
Attachment #624058 - Flags: review?(dbienvenu)
Attachment #624058 - Flags: review+
Attachment #624058 - Flags: approval-comm-beta?
Attachment #624058 - Flags: approval-comm-beta+
Depends on: 758150
Unless I hear further on this, I'm going to assume that we want to disable Dropbox on TB 14 as well.
tracking-thunderbird14: --- → ?
(In reply to Mike Conley (:mconley) from comment #8) > Unless I hear further on this, I'm going to assume that we want to disable > Dropbox on TB 14 as well. Yes. That is right.
a=me for transplanting these to latest head on beta.
tracking-thunderbird14: ? → +
Comment on attachment 623795 [details] [diff] [review] Patch v1 No risk to taking this.
Attachment #623795 - Flags: approval-comm-aurora?
Comment on attachment 624058 [details] [diff] [review] Disable Dropbox tests No risk to taking this.
Attachment #624058 - Flags: approval-comm-aurora?
Comment on attachment 623795 [details] [diff] [review] Patch v1 I don't think this will apply since we landed Ubuntu, but a=me for a patch that would apply... :-)
Attachment #623795 - Flags: approval-comm-aurora? → approval-comm-aurora+
(In reply to David :Bienvenu from comment #14) > Comment on attachment 623795 [details] [diff] [review] > Patch v1 > > I don't think this will apply since we landed Ubuntu, but a=me for a patch > that would apply... :-) Good point. I'll make sure it applies cleanly.
Attachment #624058 - Flags: approval-comm-aurora? → approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: