remove bufferToArrayHack from frameworker

RESOLVED FIXED in Firefox 17

Status

()

Firefox
SocialAPI
--
blocker
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mixedpuppy, Assigned: markh)

Tracking

unspecified
Firefox 18
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox17 fixed)

Details

(Whiteboard: [Fx17][qa-])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
moved from https://github.com/mozilla/socialapi-dev/issues/24

There are js compartment issues with Uint8Array, related to bug 734215.
(Reporter)

Updated

5 years ago
Depends on: 741041
(Reporter)

Comment 1

5 years ago
We still have a problem, now getting "permission denied to access object".
(Reporter)

Updated

5 years ago
Blocks: 762569
(Reporter)

Updated

5 years ago
Whiteboard: [ms2]

Updated

5 years ago
Whiteboard: [ms2] → [Fx17]
This should have been fixed by bug 734215 - need to re-test.
(Reporter)

Updated

5 years ago
Assignee: nobody → mhammond
(Assignee)

Comment 3

5 years ago
My testing shows this as now working correctly - but I'm leaving this open as a reminder to remove the bufferToArrayHack from frameworker (or at least create a strategy to remove it - immediate removal might break amigo in the short term)
Is the relevant functionality not covered by the landed tests? testArrayUsingBuffer seems to cover it.
Created attachment 638781 [details] [diff] [review]
remove the hack
Attachment #638781 - Flags: review?(mhammond)
(Assignee)

Comment 6

5 years ago
Comment on attachment 638781 [details] [diff] [review]
remove the hack

Yeah, testArrayUsingReader should cover it, so I guess a trivial s/todo// in browser_frameworker is also needed (I'm still getting a FF crash running that test from the addon, so I'm struggling to confirm it via the tests)
Attachment #638781 - Flags: review?(mhammond) → review+
(Assignee)

Updated

5 years ago
Hardware: x86 → All
Summary: ArrayBuffer/Uint8Array stuff not working in nightly → remove bufferToArrayHack from frameworker
(Reporter)

Comment 7

5 years ago
this hack function has not been in use for a few weeks, we can remove it.
(Assignee)

Comment 8

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f7c590243c7
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/3f7c590243c7
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
Attachment #638781 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/cb14aa3285c5
status-firefox17: --- → fixed
Does this have or need an automated testcase?
Flags: in-testsuite?
No, this is just code removal.
Flags: in-testsuite? → in-testsuite-
Whiteboard: [Fx17] → [Fx17][qa-]
You need to log in before you can comment on or make changes to this bug.