755434 - l10n repacks should not execute config.py

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[John Hopkins (:jhopkins)]

Executing config.py is problematic for Thunderbird for several reasons.  config.py does not contain Thunderbird information.  thunderbird_config.py does, but its dependencies are not met in the l10n repack environment because symlinks to Python modules that are present on a buildbot master are not present.

We should pass in argument for the required options instead of executing config.py via lib/python/release/info.py:readConfig.

The values we need are:
 stage_ssh_key
 hghost
 stage_server
 stage_username
 compare_locales_repo_path

Comment 1

[Aki Sasaki (not active)]

I'm going to get to bug 740142 at some point in the not distant future, so if there's a fast fix and a long term fix, you may want to go with the faster fix.

Comment 2

[John Hopkins (:jhopkins)]

Attachment: buildbotcustom patch

Comment 3

[John Hopkins (:jhopkins)]

Attachment: tools patch

Comment 4

[Justin Wood (:Callek)]

Comment on attachment 624196 [details] [diff] [review]
tools patch

Looks sane to me except for one minor typo, though I think you'll still want someone else to give this a look over for sure (I'm no expert on the newer repack logic)

> $PYTHON $MY_DIR/create-release-repacks.py -c $branchConfig -r $releaseConfig \
>   -b $BUILDBOT_CONFIGS -t $releaseTag -p $platform \
>-  --chunks $chunks --this-chunk $thisChunk $generatePartials
>+  --chunks $chunks --this-chunk $thisChunk $generatePartials \
>+  --stage-ssh-key=$stage_ssh_key \
>+  --stage-server=stage_server \
>+  --stage-username=stage_username \
>+  --hghost=hghost \
>+  --compare-locales-repo-path=compare_locales_repo_path \
>+  $SOURCE_REPO_KEY

Typo is here you missed many of the $ chars needed for var expansion.

Comment 5

[John Hopkins (:jhopkins)]

Attachment: tools patch (updated)

addressed Callek's feedback

Comment 6

[John Hopkins (:jhopkins)]

Planning to land the above two patches Thursday morning just before bear does a reconfig.

Comment 7

[John Hopkins (:jhopkins)]

Comment on attachment 624194 [details] [diff] [review]
buildbotcustom patch

Landed in http://hg.mozilla.org/build/buildbotcustom/rev/f79895ac8ee8

Comment 8

[John Hopkins (:jhopkins)]

Comment on attachment 624359 [details] [diff] [review]
tools patch (updated)

Landed in http://hg.mozilla.org/build/tools/rev/8396c41601a9

Comment 9

[Mike Taylor [:bear]]

in production 2012-05-17 0750 PDT

Comment 10

[John Hopkins (:jhopkins)]

standalone_repacks.sh also needs to pass in the extra arguments.  Tracking in bug 759100.