759100 - update standalone_repacks.sh to pass correct arguments to create-release-repacks.py

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, defect, P3)

Description

[[e-mail] (:bhearsum)]

bug 755434 added a bunch of extra arguments to create-release-repacks. release_repacks.sh got updated to pass them, but standalone_repacks.sh didn't.

Comment 1

[Rail Aliiev [:rail]]

Attachment: unify and simplify wrapper scripts

Comment 2

[Rail Aliiev [:rail]]

Attachment: [WIP] pass real parameters, use one wrapper for both

No more standalone_repacks.sh and sensitive order of parameters!

Comment 3

[Rail Aliiev [:rail]]

Comment on attachment 627955 [details] [diff] [review]
unify and simplify wrapper scripts

Tested in staging.

l10n repacks wrapper is called as following:
bash scripts/scripts/l10n/release_repacks.sh linux mozilla/staging_config.py --chunks 6 --this-chunk 1 --stage-ssh-key ffxbld_dsa --stage-server dev-stage01.srv.releng.scl3.mozilla.com --stage-username ffxbld --hghost hg.mozilla.org --compare-locales-repo-path users/raliiev_mozilla.com/compare-locales --generate-partials

and it calls the main script like this:

+ /tools/python/bin/python /builds/slave/rel-m-beta-lnx-rpk-1/scripts/scripts/l10n/create-release-repacks.py -c mozilla/staging_config.py -r mozilla/staging_release-firefox-mozilla-beta.py -b http://hg.mozilla.org/users/raliiev_mozilla.com/buildbot-configs -t FIREFOX_13_0b4_RELEASE -p linux --chunks 6 --this-chunk 1 --stage-ssh-key ffxbld_dsa --stage-server dev-stage01.srv.releng.scl3.mozilla.com --stage-username ffxbld --hghost hg.mozilla.org --compare-locales-repo-path users/raliiev_mozilla.com/compare-locales --generate-partials

which is identical to the one in production (compared with b6):

+ /tools/python/bin/python /builds/slave/rel-m-beta-lnx-rpk-1/scripts/scripts/l10n/create-release-repacks.py -c mozilla/production_config.py -r mozilla/release-firefox-mozilla-beta.py -b http://hg.mozilla.org/build/buildbot-configs -t FIREFOX_13_0b6_RELEASE -p linux --chunks 6 --this-chunk 1 --generate-partials --stage-ssh-key=ffxbld_dsa --stage-server=stage.mozilla.org --stage-username=ffxbld --hghost=hg.mozilla.org --compare-locales-repo-path=build/compare-locales

Repack, signing, upload work fine.

Standalone repack builder call the same wrapper without chunk information and locales in the props file:
'bash' 'scripts/scripts/l10n/release_repacks.sh' 'win32' 'mozilla/staging_config.py' '--stage-ssh-key' 'ffxbld_dsa' '--stage-server' 'dev-stage01.srv.releng.scl3.mozilla.com' '--stage-username' 'ffxbld' '--hghost' 'hg.mozilla.org' '--compare-locales-repo-path' 'users/raliiev_mozilla.com/compare-locales' '--generate-partials'

and calls the main script like this:

+ python /e/builds/moz2_slave/release-mozilla-beta-win32_standalone_repack/scripts/scripts/l10n/create-release-repacks.py -c mozilla/staging_config.py -r mozilla/staging_release-firefox-mozilla-beta.py -b http://hg.mozilla.org/users/raliiev_mozilla.com/buildbot-configs -t FIREFOX_13_0b4_RELEASE -p win32 --locale af --locale ar --locale ru --stage-ssh-key ffxbld_dsa --stage-server dev-stage01.srv.releng.scl3.mozilla.com --stage-username ffxbld --hghost hg.mozilla.org --compare-locales-repo-path users/raliiev_mozilla.com/compare-locales --generate-partials

Repack, signing, upload work fine.

A new buildbotcustom patch incoming (two lines change)

Comment 4

[Rail Aliiev [:rail]]

Attachment: pass real parameters, use one wrapper for both

* added slavebuilddir property

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 627955 [details] [diff] [review]
unify and simplify wrapper scripts

Review of attachment 627955 [details] [diff] [review]:
-----------------------------------------------------------------

Great victory!

Comment 6

[Rail Aliiev [:rail]]

Comment on attachment 627955 [details] [diff] [review]
unify and simplify wrapper scripts

http://hg.mozilla.org/build/tools/rev/006aeda1fc65

Comment 7

[Rail Aliiev [:rail]]

Comment on attachment 627963 [details] [diff] [review]
pass real parameters, use one wrapper for both

http://hg.mozilla.org/build/buildbotcustom/rev/8da3f2afbf34