Last Comment Bug 755491 - sidebar click handler overactive
: sidebar click handler overactive
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: SocialAPI (show other bugs)
: unspecified
: x86 Mac OS X
: -- blocker (vote)
: ---
Assigned To: Nobody; OK to take it and work on it
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-15 13:50 PDT by Shane Caraveo (:mixedpuppy) [on leave 5/16-7/16]
Modified: 2012-05-16 11:58 PDT (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments

Description Shane Caraveo (:mixedpuppy) [on leave 5/16-7/16] 2012-05-15 13:50:20 PDT
In the sidebar, we use nsIWebProgressListener::onLocationChange to watch for clicks, and move them into browser tabs.  This is causing problems with sidebar providers that change window.location as part of their authentication or api use, resulting in unwanted empty tabs being opened.
Comment 1 Shane Caraveo (:mixedpuppy) [on leave 5/16-7/16] 2012-05-16 11:58:20 PDT
fixed https://github.com/mozilla/socialapi-dev/commit/0fdbbc841bd148e52cade2e13d1b3c46d557c7fc

using docShell.isAppTab=true works wonders, fixes login in sidebar, etc.

Note You need to log in before you can comment on or make changes to this bug.