Last Comment Bug 755509 - Add tests to ensure that deleteDatabase sets undefined success result
: Add tests to ensure that deleteDatabase sets undefined success result
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: IndexedDB (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla15
Assigned To: Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)
:
:
Mentors:
Depends on:
Blocks: 726378
  Show dependency treegraph
 
Reported: 2012-05-15 14:26 PDT by Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)
Modified: 2012-05-22 01:43 PDT (History)
2 users (show)
khuey: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Part 1: Run deleteDatabase test in window and component scopes (9.17 KB, patch)
2012-05-17 14:09 PDT, Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)
jonas: review+
Details | Diff | Splinter Review
Part 2: Test explicitly for undefined. (1.00 KB, patch)
2012-05-17 14:10 PDT, Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)
jonas: review+
Details | Diff | Splinter Review

Description Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2012-05-15 14:26:53 PDT

    
Comment 1 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2012-05-17 14:09:47 PDT
Created attachment 624892 [details] [diff] [review]
Part 1: Run deleteDatabase test in window and component scopes

This is just moving code around.
Comment 2 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2012-05-17 14:10:55 PDT
Created attachment 624894 [details] [diff] [review]
Part 2: Test explicitly for undefined.
Comment 3 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2012-05-21 11:27:45 PDT
https://hg.mozilla.org/mozilla-central/rev/1143cf39246f
https://hg.mozilla.org/mozilla-central/rev/38c9289bdf6d
Comment 4 neil@parkwaycc.co.uk 2012-05-21 11:44:46 PDT
Comment on attachment 624894 [details] [diff] [review]
Part 2: Test explicitly for undefined.

>-  is(event.target.result, null, "event should have no result");
>+  ok(event.target.result === undefined, "event should have no result");
ise(event.target.result, undefined, "event should have undefined result");
Comment 5 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2012-05-21 12:15:49 PDT
No, is does ==, not ===.
Comment 6 :Ms2ger (⌚ UTC+1/+2) 2012-05-22 01:34:05 PDT
The 'ise' instead of 'is' was not a typo; 'ise' does use ===
Comment 7 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2012-05-22 01:43:15 PDT
Sounds like someone needs to update https://developer.mozilla.org/en/Mochitest#Test_functions then.

Note You need to log in before you can comment on or make changes to this bug.