The default bug view has changed. See this FAQ.

Revert all in-memory data when aborting versionchange transactions.

RESOLVED FIXED in mozilla16

Status

()

Core
DOM: IndexedDB
RESOLVED FIXED
5 years ago
6 months ago

People

(Reporter: khuey, Assigned: khuey)

Tracking

unspecified
mozilla16
x86_64
Windows 7
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
By the way, this includes reverting the .indexNames property on deleted objectStores.
Created attachment 637100 [details] [diff] [review]
Patch
Assignee: nobody → khuey
Status: NEW → ASSIGNED
Attachment #637100 - Flags: review?(bent.mozilla)
This patch won't revert the indexNames property for deleted object stores, will it?
Sure it will.  Look at the test.
Comment on attachment 637100 [details] [diff] [review]
Patch

Review of attachment 637100 [details] [diff] [review]:
-----------------------------------------------------------------

r- due to the deleted object stores thing.

::: dom/indexedDB/test/error_events_abort_transactions_iframe.html
@@ +156,4 @@
>        ok(db.objectStoreNames.contains("foo"), "Has correct objectStore");
> +      ok(db.objectStoreNames.contains("bar"), "Has correct objectStore");
> +
> +      db.close();

Why add this .close() call? Might be nicer to not have that to make sure that we revert even if the database isn't explicitly closed.
Attachment #637100 - Flags: review?(bent.mozilla) → review-
Created attachment 637645 [details] [diff] [review]
Patch

The db.close call is necessary to start the next versionchange transaction.
Attachment #637100 - Attachment is obsolete: true
Attachment #637645 - Flags: review?(jonas)
Attachment #637645 - Flags: review?(jonas) → review+
https://hg.mozilla.org/mozilla-central/rev/f6b519d4881b
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
See Also: → bug 1302261
You need to log in before you can comment on or make changes to this bug.