Last Comment Bug 755515 - Catch exceptions in error handlers/versionchange handlers
: Catch exceptions in error handlers/versionchange handlers
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: IndexedDB (show other bugs)
: unspecified
: x86_64 Windows 7
: -- normal (vote)
: mozilla16
Assigned To: Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)
:
: Hsin-Yi Tsai [:hsinyi]
Mentors:
Depends on:
Blocks: 726378
  Show dependency treegraph
 
Reported: 2012-05-15 14:30 PDT by Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)
Modified: 2012-06-29 11:51 PDT (History)
3 users (show)
khuey: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (14.00 KB, patch)
2012-06-26 11:18 PDT, Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)
jonas: review+
Details | Diff | Splinter Review

Description Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2012-05-15 14:30:06 PDT

    
Comment 1 :Ms2ger (⌚ UTC+1/+2) 2012-05-16 04:28:03 PDT
Please do explain :)
Comment 2 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2012-06-26 11:18:59 PDT
Created attachment 636796 [details] [diff] [review]
Patch

We already did this for success events (including versionchange).  I added code to catch exceptions from error events and some tests.
Comment 3 Jonas Sicking (:sicking) No longer reading bugmail consistently 2012-06-28 15:43:52 PDT
Actually, I talked it over with Ben and I think we should check for exception before we check if the default action should be done.

Similar to how exceptions override return values.
Comment 4 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2012-06-29 11:51:57 PDT
https://hg.mozilla.org/mozilla-central/rev/f22f90356a87

Note You need to log in before you can comment on or make changes to this bug.