755590 - Add UA override for sites.google.com - top bar doesn't show up in Firefox for Android

Status: VERIFIED FIXED

(Web Compatibility :: Interventions, defect, P1)

Description

[Jason Smith [:jsmith]]

The search bar does not appear on fennec native on the main starting page on google sites (sites.google.com) after logging in. On the stock browser, the search bar does appear. Strangely enough, this works on desktop firefox fine. Might be worth investigating to see if this is a problem on our end before determining that this is an evangelism issue.

Webkit Used:

-webkit-tap-highlight
-webkit-box-shadow
-webkit-border-radius
-webkit-box-pack
-webkit-box-orient
-webkit-box-align
-webkit-box
-webkit-gradient
-webkit-box-shadow
-webkit-background-size
-webkit-transform
-webkit-box-flex
-webkit-text-size-adjust

Comment 1

[Jason Smith [:jsmith]]

UA sniffing evident that causes the search bar to appear or not. This is an evangelism problem.

Comment 2

[Hallvord R. M. Steen [:hallvors]]

Server-side sniffing omits parts of the page, including a SCRIPT element that starts 
var searchBox = new sites.Searchbox('sites-searchbox-select-button') ...

Comment 3

[Karl Dubost💡 :karlcow]

I wonder if it's a similar issue than Bug 920466 	


1. Go to http://sites.google.com/
2. Log in to a Google Account

* on IOS there's a top bar with Google+, Gmail, Sites, Web, plus
* on Firefox for Android no top bar.


To contact.

Comment 4

[Karl Dubost💡 :karlcow]

Changing to sitewait. As we contacted them for Bug 920466.

Comment 5

[Karl Dubost💡 :karlcow]

the issue is still there, and also no top bar with Firefox OS.

Comment 6

[Karl Dubost💡 :karlcow]

Attachment: fxand-sites.png

rendered on firefox with a firefox mobile android UA

Comment 7

[Karl Dubost💡 :karlcow]

UA override + unprefixing service will sove some of the issues.

Comment 8

[Karl Dubost💡 :karlcow]

Note that Opera/Blink is being given the desktop site.

Comment 9

[Karl Dubost💡 :karlcow]

The top bar of site Google sites is appearing now only if we fake as Chrome.
With webkit prefs set to true we get the right layout.

but as Firefox + webkit prefs, no luck.

Comment 10

[Mike Taylor [:miketaylr]]

Let's do a UA override here.

Comment 11

[Mike Taylor [:miketaylr]]

Attachment: Gecko spoofing as Chrome with css.layout.prefixes.webkit=false

Comment 12

[Mike Taylor [:miketaylr]]

So, if we override this now we'll end up making it look more broken for release and beta users. We need to wait on 1259345 making it to release.

Comment 13

[Karl Dubost💡 :karlcow]

mike,

from experience, it's usually better to open a separate bug for the UA override and create a dependency.

Comment 14

[Mike Taylor [:miketaylr]]

(In reply to Karl Dubost :karlcow from comment #13)
> from experience, it's usually better to open a separate bug for the UA
> override and create a dependency.

Yeah, sorry. Will do in the future. ^_^

Note to self: when 1259345 is in Release (either 48 or 49 -- we'll know more in a few days) we can move forward with this.

Comment 15

[Mike Taylor [:miketaylr]]

Dennis, when we can do UA overrides in Fennec with gofaster, will you add one for this?

Comment 16

[Dennis Schubert [:denschub]]

Attachment: Pull Request adding the UA override

Comment 17

[Dennis Schubert [:denschub]]

The UA override is built and landing is happening in bug 1338586, so we can close this.

Comment 18

[Stefan Deiac]

Verified as fixed on Latest build of Nightly with GoFaster add-on 2.0.1 installed. 
Device: OnePlus 5T (Android 8.1.0), Nokia 6 (Android 7.1.1), Motorola Nexus 6 (Android 7.1.1).