Closed Bug 755621 Opened 12 years ago Closed 1 year ago

Add downcasting for nsXULTreeItemAccessibleBase

Categories

(Core :: Disability Access APIs, defect)

defect

Tracking

()

RESOLVED FIXED
112 Branch
Tracking Status
firefox112 --- fixed

People

(Reporter: capella, Assigned: rzvncj, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=c++])

Attachments

(2 files)

See bug 740725, bug 636945, and bug 629394 for previous downcast examples. Do the same here for nsXULTreeItemAccessibleBase.
Whiteboard: [good first bug][lang=c++]
Whiteboard: [good first bug][lang=c++] → [good first bug][mentor=trev.saunders@gmail.com][lang=c++]
Assignee: nobody → jigneshhk1992
Attached patch Patch(v1)Splinter Review
Attachment #624425 - Flags: feedback?(trev.saunders)
Comment on attachment 624425 [details] [diff] [review]
Patch(v1)

so, this patch seems "correct" but I don't think this is a particularly good idea, I tink instead we should change GetTreeItemAccessible() to return the right type in the first place, ideally by changing the cache in the same as we should do for bug 739568.
Attachment #624425 - Flags: feedback?(trev.saunders)
Assignee: jigneshhk1992 → nobody
(In reply to Trevor Saunders (:tbsaunde) from comment #2)
> Comment on attachment 624425 [details] [diff] [review]
> Patch(v1)
> 
> so, this patch seems "correct" but I don't think this is a particularly good
> idea, I tink instead we should change GetTreeItemAccessible() to return the
> right type in the first place, ideally by changing the cache in the same as
> we should do for bug 739568.

Trev, it seems we still need downcasting for XULTreeGridCellAccessible::GetSiblingAtOffset (http://mxr.mozilla.org/mozilla-central/source/accessible/src/xul/XULTreeGridAccessible.cpp#873)
Trevor, hi, I'm new here, but I'd like to work on this. Could you guide me on this one?
(In reply to Projjol [:dorsatum] from comment #4)
> Trevor, hi, I'm new here, but I'd like to work on this. Could you guide me
> on this one?

its been a while since I've looked at this, but sure.  I'd probably try and make the type of mAccessibleCache in XULTreeAccessible  nsRefPtrHashtable<nsPtrHashKey<const void>, XULTreeItemBase> and then see if there's still any place we need to downcast.
(In reply to Trevor Saunders (:tbsaunde) from comment #5)
> make the type of mAccessibleCache in XULTreeAccessible 
> nsRefPtrHashtable<nsPtrHashKey<const void>, XULTreeItemBase> and then see if
> there's still any place we need to downcast.

Are we looking at changes in http://mxr.mozilla.org/mozilla-central/source/accessible/src/xul/XULTreeAccessible.cpp#42  ? Changes in the type there?
(In reply to Trevor Saunders (:tbsaunde) from comment #5)

> make the type of mAccessibleCache in XULTreeAccessible 
> nsRefPtrHashtable<nsPtrHashKey<const void>, XULTreeItemBase> and then see if
> there's still any place we need to downcast.

That throws up compiler warning. How do i go about checking them?
(In reply to Projjol [:dorsatum] from comment #7)
> (In reply to Trevor Saunders (:tbsaunde) from comment #5)
> 
> > make the type of mAccessibleCache in XULTreeAccessible 
> > nsRefPtrHashtable<nsPtrHashKey<const void>, XULTreeItemBase> and then see if
> > there's still any place we need to downcast.
> 
> That throws up compiler warning. How do i go about checking them?

please say what they are.  Its hard to say without knowing that.
These links contain the three messages that are thrown. After the message contained in the last link I get this:
 1:29.69 make[5]: *** [Unified_cpp_accessible_src_generic0.o] Error 1
 1:29.69 make[4]: *** [accessible/src/generic/compile] Error 2
 1:31.43 make[3]: *** [compile] Error 2
 1:31.43 make[2]: *** [default] Error 2
 1:31.43 make[1]: *** [realbuild] Error 2
 1:31.43 make: *** [build] Error 2
 1:31.44 593 compiler warnings present.


http://pastebin.com/gyuYaQbX

http://pastebin.com/W9DZvpGz

http://pastebin.com/TaRhrA3J
I would like to work on this bug..Please assign me this bug.
email- sid3129@gmail.com
Assigned to Siddarth as per request in IRC.
Assignee: nobody → sid3129
Status: NEW → ASSIGNED
i understand this much that the bug is related to accessibility..its related to core component..and
th directory is /accessible..but i cant find the exact source code concerned..
I am not able to undestand which file to change or what exactly to change.
Hi, Siddarth - Are you still working on this bug?
Flags: needinfo?(sid3129)
Hi, Mike Hoye - i wasn't able to work much due to my exams but plan to work further after a week since my exams will get over..Meanwhile If anyone else wants to work on it thats fine with me.
.
Flags: needinfo?(sid3129)
Mentor: trev.saunders
Whiteboard: [good first bug][mentor=trev.saunders@gmail.com][lang=c++] → [good first bug][lang=c++]
Hi, is this bug still exists?, can i work on this as my first bug?
(In reply to grvi.osource from comment #16)
> Hi, is this bug still exists?, can i work on this as my first bug?

the bug is still actual, here's a list of all XULTreeItemAccessibleBase cases to fix [1].

[1] https://dxr.mozilla.org/mozilla-central/search?q=RefPtr%3CXULTreeItemAccessibleBase%3E&redirect=false
Mentor: tbsaunde+mozbugs → surkov.alexander
Keywords: good-first-bug
Whiteboard: [good first bug][lang=c++] → [lang=c++]

This good-first-bug hasn't had any activity for 6 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Assignee: sid3129 → nobody
Status: ASSIGNED → NEW

Does this bug still exist? Can I work on it for my first bug?

Severity: normal → S3
Assignee: nobody → rzvncj
Status: NEW → ASSIGNED
Attachment #9318120 - Attachment description: Bug 755621 - Add downcasting for nsXULTreeItemAccessibleBase. r?surkov → Bug 755621 - Add downcasting for nsXULTreeItemAccessibleBase. r?surkov,nlapre
Attachment #9318120 - Attachment description: Bug 755621 - Add downcasting for nsXULTreeItemAccessibleBase. r?surkov,nlapre → Bug 755621 - Add downcasting for nsXULTreeItemAccessibleBase. r?nlapre,Jamie
Pushed by jteh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dd93eb14eeca
Add downcasting for nsXULTreeItemAccessibleBase. r=nlapre
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: