755621 - Add downcasting for nsXULTreeItemAccessibleBase

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Mark Capella [:capella]]

See bug 740725, bug 636945, and bug 629394 for previous downcast examples. Do the same here for nsXULTreeItemAccessibleBase.

Comment 1

[Jignesh Kakadiya [:jhk]]

Attachment: Patch(v1)

Comment 2

[Trevor Saunders (:tbsaunde)]

Comment on attachment 624425 [details] [diff] [review]
Patch(v1)

so, this patch seems "correct" but I don't think this is a particularly good idea, I tink instead we should change GetTreeItemAccessible() to return the right type in the first place, ideally by changing the cache in the same as we should do for bug 739568.

Comment 3

[alexander :surkov (:asurkov)]

(In reply to Trevor Saunders (:tbsaunde) from comment #2)
> Comment on attachment 624425 [details] [diff] [review]
> Patch(v1)
> 
> so, this patch seems "correct" but I don't think this is a particularly good
> idea, I tink instead we should change GetTreeItemAccessible() to return the
> right type in the first place, ideally by changing the cache in the same as
> we should do for bug 739568.

Trev, it seems we still need downcasting for XULTreeGridCellAccessible::GetSiblingAtOffset (http://mxr.mozilla.org/mozilla-central/source/accessible/src/xul/XULTreeGridAccessible.cpp#873)

Comment 4

[Projjol [:dorsatum]]

Trevor, hi, I'm new here, but I'd like to work on this. Could you guide me on this one?

Comment 5

[Trevor Saunders (:tbsaunde)]

(In reply to Projjol [:dorsatum] from comment #4)
> Trevor, hi, I'm new here, but I'd like to work on this. Could you guide me
> on this one?

its been a while since I've looked at this, but sure.  I'd probably try and make the type of mAccessibleCache in XULTreeAccessible  nsRefPtrHashtable<nsPtrHashKey<const void>, XULTreeItemBase> and then see if there's still any place we need to downcast.

Comment 6

[Projjol [:dorsatum]]

(In reply to Trevor Saunders (:tbsaunde) from comment #5)
> make the type of mAccessibleCache in XULTreeAccessible 
> nsRefPtrHashtable<nsPtrHashKey<const void>, XULTreeItemBase> and then see if
> there's still any place we need to downcast.

Are we looking at changes in http://mxr.mozilla.org/mozilla-central/source/accessible/src/xul/XULTreeAccessible.cpp#42  ? Changes in the type there?

Comment 7

[Projjol [:dorsatum]]

(In reply to Trevor Saunders (:tbsaunde) from comment #5)

> make the type of mAccessibleCache in XULTreeAccessible 
> nsRefPtrHashtable<nsPtrHashKey<const void>, XULTreeItemBase> and then see if
> there's still any place we need to downcast.

That throws up compiler warning. How do i go about checking them?

Comment 8

[Trevor Saunders (:tbsaunde)]

(In reply to Projjol [:dorsatum] from comment #7)
> (In reply to Trevor Saunders (:tbsaunde) from comment #5)
> 
> > make the type of mAccessibleCache in XULTreeAccessible 
> > nsRefPtrHashtable<nsPtrHashKey<const void>, XULTreeItemBase> and then see if
> > there's still any place we need to downcast.
> 
> That throws up compiler warning. How do i go about checking them?

please say what they are.  Its hard to say without knowing that.

Comment 9

[Projjol [:dorsatum]]

These links contain the three messages that are thrown. After the message contained in the last link I get this:
 1:29.69 make[5]: *** [Unified_cpp_accessible_src_generic0.o] Error 1
 1:29.69 make[4]: *** [accessible/src/generic/compile] Error 2
 1:31.43 make[3]: *** [compile] Error 2
 1:31.43 make[2]: *** [default] Error 2
 1:31.43 make[1]: *** [realbuild] Error 2
 1:31.43 make: *** [build] Error 2
 1:31.44 593 compiler warnings present.


http://pastebin.com/gyuYaQbX

http://pastebin.com/W9DZvpGz

http://pastebin.com/TaRhrA3J

Comment 10

[Siddarth Goyal [:sid3129]]

I would like to work on this bug..Please assign me this bug.
email- [e-mail]

Comment 11

[Manish Goregaokar [:manishearth]]

Assigned to Siddarth as per request in IRC.

Comment 12

[Siddarth Goyal [:sid3129]]

i understand this much that the bug is related to accessibility..its related to core component..and
th directory is /accessible..but i cant find the exact source code concerned..
I am not able to undestand which file to change or what exactly to change.

Comment 13

[Manish Goregaokar [:manishearth]]

Maybe http://mxr.mozilla.org/mozilla-central/source/accessible/src/xul/XULTreeAccessible.cpp ?

Comment 14

[Mike Hoye [:mhoye]]

Hi, Siddarth - Are you still working on this bug?

Comment 15

[Siddarth Goyal [:sid3129]]

Hi, Mike Hoye - i wasn't able to work much due to my exams but plan to work further after a week since my exams will get over..Meanwhile If anyone else wants to work on it thats fine with me.
.

Comment 16

[grvi.osource]

Hi, is this bug still exists?, can i work on this as my first bug?

Comment 17

[alexander :surkov (:asurkov)]

(In reply to grvi.osource from comment #16)
> Hi, is this bug still exists?, can i work on this as my first bug?

the bug is still actual, here's a list of all XULTreeItemAccessibleBase cases to fix [1].

[1] https://dxr.mozilla.org/mozilla-central/search?q=RefPtr%3CXULTreeItemAccessibleBase%3E&redirect=false

Comment 18

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 6 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 19

[Ruby Alesi]

Does this bug still exist? Can I work on it for my first bug?

Comment 20

[Razvan Cojocaru]

Attachment: Bug 755621 - Add downcasting for nsXULTreeItemAccessibleBase. r?nlapre,Jamie

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd93eb14eeca
Add downcasting for nsXULTreeItemAccessibleBase. r=nlapre

Comment 22

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/dd93eb14eeca