It would be desirable to match http://24.media.tumblr.com/tumblr_m0it9bMzM51qkoea4o1_1280.png * No colored icons * The pin needs to be square on selected
Created attachment 624712 [details] [diff] [review] patch First try to style the QFB bar with amateurish icons. I'm using the mockup's toolbar colors. Additionally I'm using -moz-mac-chrome-inactive on this bar when TB is inactive. The buttons have now a height of 16 px like mockup. I removed the hover state. No other toolbar-button has now a hover state. But I added the active state with slightly darker icons like the other toolbar-buttons. Andreas, if you like this, please can you make professional icons?
The selected button state needs a bit of gradient inside the button, and the Quick Filter label needs to be slightly lighter. Apart from that it looks good!
Comment on attachment 624712 [details] [diff] [review] patch adding feedback+
Created attachment 624729 [details] [diff] [review] full patch with amateurish icons Selected buttons have now a gradient and a bottom border. Also reduced the left/right padding from 8px to 4px. The Quick Filter label is lighter now.
Comment on attachment 624729 [details] [diff] [review] full patch with amateurish icons Adding f? to Andreas to not forget to make correct icons.
Created attachment 636326 [details] [diff] [review] patch with updated graphics Here is Richards patch with new icons.
Created attachment 636345 [details] [diff] [review] Patch To not let Andreas review his own icons I'm asking Blake for review.
Comment on attachment 636345 [details] [diff] [review] Patch Looks nice, ui-r=me! And I see no problems with the code either, so r=me, too! Thanks, Blake.
Unfortunately, I had to back this out due to causing OSX Mozmill failures. https://hg.mozilla.org/comm-central/rev/b7e38513bdb2 https://tbpl.mozilla.org/php/getParsedLog.php?id=13033435&tree=Thunderbird-Trunk TEST-UNEXPECTED-FAIL | /Users/cltbld/talos-slave/test/build/mozmill/session-store/test-session-store.js | test-session-store.js::test_message_pane_width_persistence
David, you are a MozMill specialist. Please can you check if the test needs a change. I've almost no knowledge in JS and would apreciate your help. My patch changes the width of the QuickFilter buttons and this can end in a different width of the message pane.
Created attachment 639154 [details] [diff] [review] Fix Mozmill tests
Comment on attachment 639154 [details] [diff] [review] Fix Mozmill tests Hey Mark, not sure if you're the right person for this r? - let me know if I should redirect. You're probably wondering why the tests need to be changed at all... well, to be honest, I'm not sure. Something about Richard's style change upset the way this test runs - in particular, it upset the way the splitter is selected and moved on OSX. Unfortunately, I wasn't able to determine *why* the splitter is putting up such a fuss. Having read the comments in the test, I don't think I'm the first one to wrestle with that one too. Like the comments say, however, the splitter isn't the thing being tested here - it's simply the storage and retrieval of session state. So I don't think we're weakening the tests very much with this change. Try builds with this patch: https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=c0729949d03a