Australis - quickfilter toolbar styling

RESOLVED FIXED in Thunderbird 17.0

Status

Thunderbird
Theme
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: andreasn, Assigned: Paenglab)

Tracking

(Blocks: 1 bug)

Trunk
Thunderbird 17.0
All
Mac OS X
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 5 obsolete attachments)

(Reporter)

Description

5 years ago
It would be desirable to match http://24.media.tumblr.com/tumblr_m0it9bMzM51qkoea4o1_1280.png

* No colored icons
* The pin needs to be square on selected
(Reporter)

Updated

5 years ago
Blocks: 733856
(Assignee)

Comment 1

5 years ago
Created attachment 624712 [details] [diff] [review]
patch

First try to style the QFB bar with amateurish icons.

I'm using the mockup's toolbar colors. Additionally I'm using -moz-mac-chrome-inactive on this bar when TB is inactive.
The buttons have now a height of 16 px like mockup.
I removed the hover state. No other toolbar-button has now a hover state. But I added the active state with slightly darker icons like the other toolbar-buttons.

Andreas, if you like this, please can you make professional icons?
Attachment #624712 - Flags: feedback?(nisses.mail)
(Assignee)

Comment 2

5 years ago
Created attachment 624713 [details]
patch in action
(Reporter)

Comment 3

5 years ago
The selected button state needs a bit of gradient inside the button, and the Quick Filter label needs to be slightly lighter. Apart from that it looks good!
(Reporter)

Comment 4

5 years ago
Comment on attachment 624712 [details] [diff] [review]
patch

adding feedback+
Attachment #624712 - Flags: feedback?(nisses.mail) → feedback+
(Assignee)

Comment 5

5 years ago
Created attachment 624729 [details] [diff] [review]
full patch with amateurish icons

Selected buttons have now a gradient and a bottom border.
Also reduced the left/right padding from 8px to 4px.
The Quick Filter label is lighter now.
Attachment #624712 - Attachment is obsolete: true
(Assignee)

Comment 6

5 years ago
Comment on attachment 624729 [details] [diff] [review]
full patch with amateurish icons

Adding f? to Andreas to not forget to make correct icons.
Attachment #624729 - Flags: feedback?(nisses.mail)
(Reporter)

Comment 7

5 years ago
Created attachment 636326 [details] [diff] [review]
patch with updated graphics

Here is Richards patch with new icons.
Attachment #624729 - Attachment is obsolete: true
Attachment #624729 - Flags: feedback?(nisses.mail)
(Assignee)

Comment 8

5 years ago
Created attachment 636345 [details] [diff] [review]
Patch

To not let Andreas review his own icons I'm asking Blake for review.
Assignee: nobody → richard.marti
Attachment #624713 - Attachment is obsolete: true
Attachment #636326 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #636345 - Flags: ui-review?(bwinton)
Attachment #636345 - Flags: review?(bwinton)
Comment on attachment 636345 [details] [diff] [review]
Patch

Looks nice, ui-r=me!

And I see no problems with the code either, so r=me, too!

Thanks,
Blake.
Attachment #636345 - Flags: ui-review?(bwinton)
Attachment #636345 - Flags: ui-review+
Attachment #636345 - Flags: review?(bwinton)
Attachment #636345 - Flags: review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/10bcebfa5b36
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 16.0
Unfortunately, I had to back this out due to causing OSX Mozmill failures.
https://hg.mozilla.org/comm-central/rev/b7e38513bdb2

https://tbpl.mozilla.org/php/getParsedLog.php?id=13033435&tree=Thunderbird-Trunk
TEST-UNEXPECTED-FAIL | /Users/cltbld/talos-slave/test/build/mozmill/session-store/test-session-store.js | test-session-store.js::test_message_pane_width_persistence
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: Thunderbird 16.0 → ---
Status: REOPENED → ASSIGNED
(Assignee)

Comment 12

5 years ago
David, you are a MozMill specialist. Please can you check if the test needs a change. I've almost no knowledge in JS and would apreciate your help.

My patch changes the width of the QuickFilter buttons and this can end in a different width of the message pane.
Created attachment 639128 [details] [diff] [review]
Fix tests
Created attachment 639154 [details] [diff] [review]
Fix Mozmill tests
Attachment #639128 - Attachment is obsolete: true
Comment on attachment 639154 [details] [diff] [review]
Fix Mozmill tests

Hey Mark, not sure if you're the right person for this r? - let me know if I should redirect.

You're probably wondering why the tests need to be changed at all... well, to be honest, I'm not sure. Something about Richard's style change upset the way this test runs - in particular, it upset the way the splitter is selected and moved on OSX.

Unfortunately, I wasn't able to determine *why* the splitter is putting up such a fuss. Having read the comments in the test, I don't think I'm the first one to wrestle with that one too.

Like the comments say, however, the splitter isn't the thing being tested here - it's simply the storage and retrieval of session state. So I don't think we're weakening the tests very much with this change.

Try builds with this patch: https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=c0729949d03a
Attachment #639154 - Flags: review?(mbanner)

Updated

5 years ago
Blocks: 737347
Attachment #639154 - Flags: review?(mbanner) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Whiteboard: Pls check-in Patch and 'Fix Mozmill tests'
https://hg.mozilla.org/comm-central/rev/07e612f0fd78
https://hg.mozilla.org/comm-central/rev/aa3b62e61a85
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: Pls check-in Patch and 'Fix Mozmill tests'
Target Milestone: --- → Thunderbird 17.0
You need to log in before you can comment on or make changes to this bug.