Australis - taller toolbar

RESOLVED FIXED

Status

Thunderbird
Theme
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: andreasn, Assigned: Paenglab)

Tracking

Trunk
All
Windows 7

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: Fixed by Bug 763308)

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
The toolbar needs to be taller in order to match the mockup [1].
Currently the buttons are almost touching the borders.

1. http://25.media.tumblr.com/tumblr_m0iwtyy6nh1qkoea4o1_1280.png
(Reporter)

Updated

6 years ago
Blocks: 733854
(Assignee)

Comment 1

6 years ago
Created attachment 624494 [details] [diff] [review]
patch

This patch give a min-height of 41px inclusive bottom border. The top border is from tabs-toolbar. This gives the 42px like on mockup.

I centered the toolbar in the toolbox. when two toolbars are used this grows the toolbox only slightly instead of a 84px tall toolbox. I hope this is how it's planned to work. This patch works also for toolboxes in other tabs like Chat and Lightning.

Because the same should be for OSX I expanded the patch also for this. See 
http://24.media.tumblr.com/tumblr_m0it9bMzM51qkoea4o1_1280.png

Additionally I centered the OSX searchbox through giving the same top and bottom margin.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #624494 - Flags: ui-review?(nisses.mail)
Attachment #624494 - Flags: review?(nisses.mail)
(Reporter)

Comment 2

6 years ago
Comment on attachment 624494 [details] [diff] [review]
patch

Looks good ui and code-wise.
Attachment #624494 - Flags: ui-review?(nisses.mail)
Attachment #624494 - Flags: ui-review+
Attachment #624494 - Flags: review?(nisses.mail)
Attachment #624494 - Flags: review+
(Assignee)

Comment 3

6 years ago
Fixed by Bug 763308
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: Fixed by Bug 763308
You need to log in before you can comment on or make changes to this bug.