The default bug view has changed. See this FAQ.

Shut down indexedDB on profile-before-change

RESOLVED FIXED in mozilla16

Status

()

Core
DOM: IndexedDB
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ben Turner (not reading bugmail, use the needinfo flag!), Assigned: khuey)

Tracking

unspecified
mozilla16
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

1.74 KB, patch
Ben Turner (not reading bugmail, use the needinfo flag!)
: review+
Details | Diff | Splinter Review
We shut everything down at xpcom-shutdown currently and that's too late. We rely on the profile directory (and we want to support fast _exit()) so we should use profile-before-change.
Assignee: nobody → khuey
Blocks: 726378
Created attachment 629935 [details] [diff] [review]
Patch

I wrote this last week.  It appears to just work.
Attachment #629935 - Flags: review?(bent.mozilla)
Comment on attachment 629935 [details] [diff] [review]
Patch

Review of attachment 629935 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/indexedDB/IndexedDatabaseManager.cpp
@@ +238,5 @@
>      nsCOMPtr<nsIObserverService> obs = GetObserverService();
>      NS_ENSURE_TRUE(obs, nsnull);
>  
>      // We need this callback to know when to shut down all our threads.
> +    rv = obs->AddObserver(instance, "profile-before-change", false);

Nit: Let's use a #define
Attachment #629935 - Flags: review?(bent.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/0099fbd7c5f3
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.