Debug tests should always download symbol zip

RESOLVED FIXED

Status

Release Engineering
General Automation
P2
normal
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: khuey, Assigned: catlee)

Tracking

({regression})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [tests])

Attachments

(1 attachment)

Right now our assertion stacks are totally busted because we don't download symbols.
I thought we were downloading on demand now, per bug 561754?
Component: Release Engineering: Automation (Release Automation) → Release Engineering: Automation (General)
QA Contact: bhearsum → catlee
Yeah, but it ignored bug 561754 comment 30, which said that we would still need to download symbols for all debug tests, since printing assertion stacks requires symbols, and that doesn't know how to download on demand, and download on demand would be pointless since demand is "every single debug test run ever, for all time" because we'll never be assertion-free.
Blocks: 561754
Keywords: regression
So who is going to make this happen?
(Assignee)

Comment 4

6 years ago
moi
Assignee: nobody → catlee
(Assignee)

Updated

6 years ago
Priority: -- → P2
Whiteboard: [tests]
(Assignee)

Comment 6

6 years ago
pong - this is getting bumped by higher priority work ATM. I may have some time next week to look at it.
Blocks: 773163
Blocks: 775467
No longer blocks: 775467
Talked to dbaron a bit, he says if we stopped running the stack fixing scripts on the machines we could process the logs offline to get usable stacks on Mac/Linux.
I would really really like to see this fixed. I just spent hours trying to reproduce assertions locally and failed; if I could get the stacks from tinderbox I wouldn't have had to do that. As it is, I don't know how I'm going to figure out this problem so I can get my code landed.
(Assignee)

Comment 9

5 years ago
Created attachment 692461 [details] [diff] [review]
ignore download_symbols_ondemand for debug tests
Attachment #692461 - Flags: review?(aki)

Comment 10

5 years ago
Comment on attachment 692461 [details] [diff] [review]
ignore download_symbols_ondemand for debug tests

I'm not sure if I have to make a similar change in mozharness/scripts/desktop_unittest.py.

Adding to my todo list
Attachment #692461 - Flags: review?(aki) → review+
(Assignee)

Updated

5 years ago
Attachment #692461 - Flags: checked-in+

Comment 11

5 years ago
This is in production.
(Assignee)

Comment 12

5 years ago
Please re-open if this isn't working properly
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
This does not seem to work properly yet for the Jetpack tree. We're hitting an assertion, but aren't seeing any debug symbols in the resulting stack trace (bug 629263)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Updated

5 years ago
Assignee: catlee → nobody
That bug is marked FIXED, so if there's additional work to do here please file a new bug.
Assignee: nobody → catlee
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.