755852 - Use high res favicons (i.e. sizes attribute) for internal pages

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Favicon Handling, defect)

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Patch

This is my patch from bug 739215

Comment 2

[Wesley Johnston (:wesj)]

Attachment: Patch

No. That wasn't it. This is it.

Comment 3

[:Margaret Leibovic]

Comment on attachment 624478 [details] [diff] [review]
Patch

Review of attachment 624478 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/chrome/content/about.xhtml
@@ +56,5 @@
>    <meta name="viewport" content="width=480; initial-scale=.6667; user-scalable=no"/>
>    <title>&aboutPage.title;</title>
>    <link rel="stylesheet" href="chrome://browser/skin/aboutPage.css" type="text/css"/>
> +  <link rel="icon" type="image/png" sizes="32 32" href="chrome://branding/content/favicon32.png" />
> +  <link rel="icon" type="image/png" sizes="64 64" href="chrome://branding/content/favicon64.png" />

The sizes attribute is supposed to be of the format sizes="64x64":
http://www.whatwg.org/specs/web-apps/current-work/multipage/links.html#attr-link-sizes

Comment 4

[Aaron Train [:aaronmt]]

Bump?

Bug 792373 landed, what about this one?

Comment 5

[Peter Retzer (:pretzer)]

Chis, is this bug maybe also fixed by your recent favicon work and can therefore be closed/duped?

Comment 6

[Chris Kitching [:ckitching]]

(In reply to Peter Retzer (:pretzer) from comment #5)
> Chis, is this bug maybe also fixed by your recent favicon work and can
> therefore be closed/duped?

Yes and no.

This bug is about adding the sizes attributes to the internal pages, and providing high res favicons for them, right?

This is not a problem I have solved (And one that Margaret and Wes seem to have under control).

Support for parsing the sizes attribute them is partial. That much I am solving - it's expanded to full support by Bug 914952, which is likely to be solved as a side-effect of by Bug 914027 which is stalled waiting on Bug 914296.

So, most probably, no. Looking at Margaret's last comment it's not much work to give this bug the little nudge it needs to be finished.

Comment 7

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.