Open Bug 755852 Opened 8 years ago Updated 4 years ago

Use high res favicons (i.e. sizes attribute) for internal pages

Categories

(Firefox for Android :: Favicon Handling, defect)

defect
Not set

Tracking

()

People

(Reporter: wesj, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch Patch (obsolete) — Splinter Review
This is my patch from bug 739215
Attached patch PatchSplinter Review
No. That wasn't it. This is it.
Attachment #624476 - Attachment is obsolete: true
Comment on attachment 624478 [details] [diff] [review]
Patch

Review of attachment 624478 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/chrome/content/about.xhtml
@@ +56,5 @@
>    <meta name="viewport" content="width=480; initial-scale=.6667; user-scalable=no"/>
>    <title>&aboutPage.title;</title>
>    <link rel="stylesheet" href="chrome://browser/skin/aboutPage.css" type="text/css"/>
> +  <link rel="icon" type="image/png" sizes="32 32" href="chrome://branding/content/favicon32.png" />
> +  <link rel="icon" type="image/png" sizes="64 64" href="chrome://branding/content/favicon64.png" />

The sizes attribute is supposed to be of the format sizes="64x64":
http://www.whatwg.org/specs/web-apps/current-work/multipage/links.html#attr-link-sizes
Bump?

Bug 792373 landed, what about this one?
Chis, is this bug maybe also fixed by your recent favicon work and can therefore be closed/duped?
Flags: needinfo?(chriskitching)
(In reply to Peter Retzer (:pretzer) from comment #5)
> Chis, is this bug maybe also fixed by your recent favicon work and can
> therefore be closed/duped?

Yes and no.

This bug is about adding the sizes attributes to the internal pages, and providing high res favicons for them, right?

This is not a problem I have solved (And one that Margaret and Wes seem to have under control).

Support for parsing the sizes attribute them is partial. That much I am solving - it's expanded to full support by Bug 914952, which is likely to be solved as a side-effect of by Bug 914027 which is stalled waiting on Bug 914296.

So, most probably, no. Looking at Margaret's last comment it's not much work to give this bug the little nudge it needs to be finished.
Flags: needinfo?(chriskitching)
Blocks: 999920
Component: General → Favicon Handling
You need to log in before you can comment on or make changes to this bug.