756450 - Localized default bookmarks bust the build with ' in the bookmarks names

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Axel Hecht [:Pike]]

The bookmarks.ini file is not meant to be included in android strings.xml, and thus doesn't escape apostrophes.

I'm afraid we'll need to post-process the titles to get all locales to build.

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

To Tester: should test other special characters such as " \' # @ % & ~ ? < > [ ], etc.

Comment 2

[Alex Keybl [:akeybl]]

Spoke with Axel and Aki over email - this is a release blocker if we plan to build/ship the Irish Gaelic, Ganda, and Songhai locales. Re-nominating.

Comment 3

[Wesley Johnston (:wesj)]

The only reason we're sharing strings with XUL Fennec is because I wanted to avoid extra churn in strings. For future versions, localizers could fill the strings in direction in our strings.xml.

Comment 4

[Johnathan Nightingale [:johnath]]

(In reply to Alex Keybl [:akeybl] from comment #2)
> Spoke with Axel and Aki over email - this is a release blocker if we plan to
> build/ship the Irish Gaelic, Ganda, and Songhai locales. Re-nominating.

Provisionally minusing. We don't expect these locales to be release-blocking, but Alex/Axel please re-nom if you hear otherwise from Jay, or wish to assert otherwise yourselves!

Comment 5

[Alex Keybl [:akeybl]]

(In reply to Johnathan Nightingale [:johnath] from comment #4)
> Provisionally minusing. We don't expect these locales to be
> release-blocking, but Alex/Axel please re-nom if you hear otherwise from
> Jay, or wish to assert otherwise yourselves!

That sounds like a plan. Still haven't heard back.

Comment 6

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.