756491 - SecReview: Land module loader to firefox

Status: VERIFIED FIXED

(mozilla.org :: Security Assurance: Review Request, task)

Description

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

1. Who is/are the point of contact(s) for this review?

Me Irakli Gozalishvili @gozala on IRC

2. Please provide a short description of the feature / application (e.g. problem solved, use cases, etc.):

Intent is to land generic CommonJS type module loader to the firefox so that other projects can start authoring their features in CommonJS style making it easy for SDK based add-ons consume them.

3. Please provide links to additional information (e.g. feature page, wiki) if available and not yet included in feature description:

https://wiki.mozilla.org/Add-on_SDK_in_Firefox

4. Does this request block another bug? If so, please indicate the bug number
https://bugzilla.mozilla.org/show_bug.cgi?id=743359

5. This review will be scheduled amongst other requested reviews. What is the urgency or needed completion date of this review?

Our Q2 goal is to land this loader to Firefox.

6. Does this feature or code change affect Firefox, Thunderbird or any product or service the Mozilla ships to end users?

It affects in sense that code will be there and later SDK will use that loader instead of shipping one with each add-on.


7. Are there any portions of the project that interact with 3rd party services?

No

8. Will your application/service collect user data? If so, please describe 

No

Comment 1

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

I showed slides on how to use this loader at firefox work week
https://speakerdeck.com/u/gozala/p/commonjs-module-loader-in-firefox

Comment 2

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Would be great if we could do it on May 25 at 10:00

Comment 3

[Curtis Koenig [:curtisk-use curtis.koenig+bzATgmail.com]]]

SecReview Scheduled:
https://mail.mozilla.com/home/[e-mail]/Security%20Review.html?view=month&action=view&invId=110490-110489&pstat=AC&exInvId=110490-180042&useInstance=1&instStartTime=1337965200000&instDuration=3600000

Comment 4

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

It may be little late, but still here is a documentation for the code that is going to land https://github.com/Gozala/addon-sdk/blob/a6c59193cb589db669b666707285c43bbded50b6/packages/api-utils/docs/loader.md

Comment 5

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Can we close this bug now ?

Comment 6

[Curtis Koenig [:curtisk-use curtis.koenig+bzATgmail.com]]]

that would be up to :dveditz but this one appears done to me

Comment 7

[Bugzilla]

Whiteboard has typo: [competed secreview] -> [completed secreview]
(it doesn't appear I can fix this myself {no permissions?} or I would've)

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

A few months later, I'm closing this bug. Reopen if that's not what should happen?