Closed Bug 756533 Opened 12 years ago Closed 10 years ago

Kitsune inheritance cleanup

Categories

(developer.mozilla.org Graveyard :: Code Cleanup, defect)

Product:
developer.mozilla.org Graveyard
Component:
Code Cleanup
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: lorchard, Assigned: jezdez)

References

Details

When the kitsune code base was combined with the devmo code base, we inherited a lot of code that we're not using. That's both a maintenance issue and a potential security issue. We should spend some time cleaning that up, with this as the tracking blocker bug. For example, these apps are not in use as far as I can tell (there may be more): * chat, customercare, dashboards, forums, gallery, humans, inproduct, kadmin, kbforums, questions, twitter, upload I'd advise removing them entirely, along with any others not in use. We shouldn't hang on to them in the hopes they *might* be handy someday, because: * Kitsune's over a year older since we forked, and lots has been done since then that we should revisit * We might never use these some of these apps at all * Even if we want something like one of them, we should consider use cases and may come up with something entirely different. A caveat: there are likely dependencies on these apps in the apps that we *do* use, so removing them needs to go slowly and with a run of tests after each. This will be tedious work.
Oh, another thing of note: We have an app called `devmo` and another called `sumo`. The former was around before the Kitsune inheritance, and the latter came from Kitsune. They overlap in a lot of interesting and conflicting ways. They also serve a lot of the same purposes as the `funfactory` app from the Playdoh project. It would be useful to finally resolve the differences between `devmo` and `sumo` into one app, and/or possibly replace that app with `funfactory` so we can outsource some core improvements to the webdev team at large.
Blocks: 756536
No longer blocks: 756266
Blocks: 756266
(In reply to Les Orchard [:lorchard] from comment #0) > * chat, customercare, dashboards, forums, gallery, humans, inproduct, > kadmin, kbforums, questions, twitter, upload > > I'd advise removing them entirely, along with any others not in use. We > shouldn't hang on to them in the hopes they *might* be handy someday, > because: +100, with three possible exceptions: * `kadmin` is just a place to collect admin views (things that we plug into with AdminPlus) like /admin/settings and /admin/env. Those are generically useful, others may not be. Since Kuma starts with a 'k', I'd say keep it and just change kadmin.admin as you need to. * `kbforums` is the discussion-forum-per-article app. If you don't need the feature, drop it like a bad habit. * `upload` contains a lot of utility stuff for uploading files. It can probably be done better or superseded by newer stuff in Django, and maybe MDN has wildly different requirements, but it's worth a little more consideration.
Version: Kuma → unspecified
Component: Docs Platform → Editing
No longer blocks: 756266
Les, I think this shouldn't be in the Editing buckets. Moving to MDN/General
Component: Editing → General
Is this bug still outstanding? Looks like all but 2 of the apps listed in comment 0 are gone, and one of those has recently been moved.
Flags: needinfo?(lcrouch)
Still relevant if for no other reason than to combine 'devmo' and 'sumo' apps as mentioned in comment 1.
Flags: needinfo?(lcrouch)
Component: General → Code Cleanup
Status: NEW → ASSIGNED
Assignee: nobody → jezdez
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Commits pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/32a6c8b9b9b3447f0c4192613ba58947ae8e1396 Bug 756533 - Define a root kuma logger so that logging doesn't raise a warning. https://github.com/mozilla/kuma/commit/745a17384e3c9ab73068b0727331813eff7cea43 Bug 756533 - Move actioncounters test model into own package. This prevents the creation of the table in non test environments. https://github.com/mozilla/kuma/commit/3b4446d6ae0368dde12b7aeb0ce43d9866bee4ff Merge pull request #3011 from mozilla/bug756533-2 Bug 756533 - For a handful of fixes
Commits pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/c6183e141c2518d205bb9827eb1d888b71ba3f51 Bug 756533 - Move the LOCALES setting population inline. This prevents a hard to trace circular import. https://github.com/mozilla/kuma/commit/96d0d221bb3d297b4af1bcb9e66ebe614f351533 Bug 756533 - Simplify the default logging setup to get rid of the RequireDebugTrue filter that break the world. https://github.com/mozilla/kuma/commit/0ef5be1777512b6e6e4da7aebaf9dfe321ffb3ef Merge pull request #3015 from mozilla/bug756533-3 A few more fixes for bug 756533.
Commits pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/b74d5326703db46e1d6ae881e317f913e803a0c1 Bug 756533 - Simplified test command for Travis. Also prints the coverage report on Travis-CI. https://github.com/mozilla/kuma/commit/0d3153589ed0d0eb1d8029001eada21239ee6655 Merge pull request #3016 from mozilla/bug756533-4 Bug 756533 - Simplified test command for Travis.
Commits pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/5665b9421662d6b35607f0e9643a99ad1bbe99ad Bug 756533 - Slightly revert logging changes from 96d0d221bb3d297b4af1bcb9e66ebe614f351533. This increases the logging threadshold to just errors and reintroduces the RequireDebugFalse filter for the admin email log handler. https://github.com/mozilla/kuma/commit/19ec5a9646e3a30152fa32b11135fd768d6d4d64 Merge pull request #3035 from mozilla/logging Bug 756533 - Slightly revert logging changes from 96d0d221bb3d297b4af1bcb9e66ebe614f351533.
Product: developer.mozilla.org → developer.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.