756786 - xulrunner won't start on linux (and probably mac)

Status: RESOLVED FIXED

(Toolkit Graveyard :: XULRunner, defect)

Description

[Mike Hommey [:glandium]]

(I think this also affects mac)

Bug 743560 moved run-mozilla.sh to the SDK. But xulrunner is still the script that calls run-mozilla.sh to call xulrunner-bin. This makes running xulrunner application.ini fail. (although, using the stub works).

We should either ship run-mozilla.sh again with xulrunner (easy) or switch xulrunner to the standalone glue (less easy, but all other apps have been switched already, so it's mostly copy/paste)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Remove NSPR usage from nsXULRunnerApp.cpp

Comment 2

[Mike Hommey [:glandium]]

Attachment: Use XPCOM standalone glue in nsXULRunnerApp.cpp

Comment 3

[Benjamin Smedberg]

Comment on attachment 629710 [details] [diff] [review]
Use XPCOM standalone glue in nsXULRunnerApp.cpp

I don't think we need/want AutoXPCOMGlue, because XPCOMGlueShutdown is pretty much a joke that should be removed. r=me with that removed

Comment 4

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4b6d2c6c1bae

Comment 5

[Mike Hommey [:glandium]]

err, there were 2 parts. Here is the second:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d8764ae15bf1

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4b6d2c6c1bae
https://hg.mozilla.org/mozilla-central/rev/d8764ae15bf1

Comment 7

[Mike Hommey [:glandium]]

Comment on attachment 629708 [details] [diff] [review]
Remove NSPR usage from nsXULRunnerApp.cpp

[Approval Request Comment]
Bug caused by bug 743560
User impact if declined: xulrunner doesn't work on linux (and maybe mac)
Risk to taking this patch (and alternatives if risky): No code change that affects Firefox. Only affects xulrunner.

Comment 8

[Mike Hommey [:glandium]]

Comment on attachment 629710 [details] [diff] [review]
Use XPCOM standalone glue in nsXULRunnerApp.cpp

[Approval Request Comment]
See comment 7.

Comment 9

[Mike Hommey [:glandium]]

http://hg.mozilla.org/releases/mozilla-aurora/rev/2da5a0ff4bd5
http://hg.mozilla.org/releases/mozilla-aurora/rev/62b82be13ebd
http://hg.mozilla.org/releases/mozilla-beta/rev/db2d1dd99271
http://hg.mozilla.org/releases/mozilla-beta/rev/f11c642254b2

Comment 10

[Mike Hommey [:glandium]]

Gah, it appears the patch was not enough: the script hasn't been modified and still tries to run run-mozilla.sh. The xulrunner script needs to go, and xulrunner-bin needs to be renamed as xulrunner.

Comment 11

[Mike Hommey [:glandium]]

Attachment: Install the xulrunner binary as xulrunner instead of xulrunner-bin, and get rid of the xulrunner wrapper script

Comment 12

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/43a69b4981f5

Comment 13

[Ed Morley [:emorley]]

Push backed out for Windows mochitest crashes:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=eecd3aa199e6

https://hg.mozilla.org/integration/mozilla-inbound/rev/1abfd50c8be6

Comment 14

[Mike Hommey [:glandium]]

Relanded, as it was innocent
https://hg.mozilla.org/integration/mozilla-inbound/rev/c8f38098799a

Comment 15

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c8f38098799a

Comment 16

[Axel Beckert]

Any reason why "status-firefox16: affected" has been removed? For me, xulrunner 16 is clearly affected in the same way as xulrunner 14 and 15 are:

$ xulrunner-16.0
Cannot find XULRunner runtime directory. Exiting.

Comment 17

[Mike Hommey [:glandium]]

Comment on attachment 644666 [details] [diff] [review]
Install the xulrunner binary as xulrunner instead of xulrunner-bin, and get rid of the xulrunner wrapper script

[Approval Request Comment]
Bug caused by bug 743560 ; previous fix was incomplete
User impact if declined: xulrunner doesn't work on linux (and maybe mac)
Risk to taking this patch (and alternatives if risky): No code change that affects Firefox. Only affects xulrunner.

Comment 18

[Scoobidiver (away)]

(In reply to Axel Beckert from comment #16)
> Any reason why "status-firefox16: affected" has been removed? For me,
> xulrunner 16 is clearly affected in the same way as xulrunner 14 and 15 are:
Because the first patches landed on 16.0, but not the latest one.

Comment 19

[Mike Hommey [:glandium]]

http://hg.mozilla.org/releases/mozilla-aurora/rev/fa4cb266be04
http://hg.mozilla.org/releases/mozilla-beta/rev/de001727ae4e

Comment 20

[Mike Hommey [:glandium]]

Comment on attachment 644666 [details] [diff] [review]
Install the xulrunner binary as xulrunner instead of xulrunner-bin, and get rid of the xulrunner wrapper script

The released xulrunner is broken on (at least) linux. The patch only changes xulrunner code, is it possible (and desirable) to do a xulrunner-only point release?

Comment 21

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 644666 [details] [diff] [review]
Install the xulrunner binary as xulrunner instead of xulrunner-bin, and get rid of the xulrunner wrapper script

Checked with RelEng and it's not possible to rebuild xulrunner without building Firefox as well so this would be too much of a PITA to do when we'll have a new beta out this week with this patch in it and a new release of xulrunner in ~2 weeks.