Closed Bug 756927 Opened 13 years ago Closed 12 years ago

Intermittent test_bug733553.html | Test 4 big.png width not correct - got 40, expected 3000

Categories

(Core :: Graphics: ImageLib, defect)

Product:
Core
Component:
Graphics: ImageLib
Platform:
x86
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME
Milestone:
mozilla15

People

(Reporter: philor, Assigned: unusualtears)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 1 obsolete file)

Stop including big.png in the test, as it can take a bit to decode.
1.70 KB, patch
joe
: review+
Details | Diff | Splinter Review
https://tbpl.mozilla.org/php/getParsedLog.php?id=11899480&tree=Mozilla-Inbound Rev3 WINNT 6.1 mozilla-inbound debug test mochitests-4/5 on 2012-05-20 02:56:59 PDT for push 443c0c79e54f slave: talos-r3-w7-009 12933 INFO TEST-PASS | /tests/image/test/mochitest/test_bug733553.html | Test 3 lime100x100.svg width not correct - 100 should equal 100 --DOMWINDOW == 20 (10B3C308) [serial = 610] [outer = 00000000] [url = http://mochi.test:8888/tests/image/test/mochitest/bug671906-iframe.html] 12934 ERROR TEST-UNEXPECTED-FAIL | /tests/image/test/mochitest/test_bug733553.html | Test 4 big.png width not correct - got 40, expected 3000 12935 INFO TEST-PASS | /tests/image/test/mochitest/test_bug733553.html | Test 5 animated-gif2.gif width not correct - 40 should equal 40 https://tbpl.mozilla.org/php/getParsedLog.php?id=11906744&tree=Mozilla-Inbound Rev3 WINNT 6.1 mozilla-inbound debug test mochitests-4/5 on 2012-05-20 17:03:45 PDT for push 9a684c3344a5 slave: talos-r3-w7-075 12933 INFO TEST-PASS | /tests/image/test/mochitest/test_bug733553.html | Test 3 lime100x100.svg width not correct - 100 should equal 100 --DOMWINDOW == 37 (188458F0) [serial = 610] [outer = 00000000] [url = http://mochi.test:8888/tests/image/test/mochitest/bug671906-iframe.html] 12934 ERROR TEST-UNEXPECTED-FAIL | /tests/image/test/mochitest/test_bug733553.html | Test 4 big.png width not correct - got 40, expected 3000 12935 INFO TEST-PASS | /tests/image/test/mochitest/test_bug733553.html | Test 5 animated-gif2.gif width not correct - 40 should equal 40
Thanks philor! > 12933 INFO TEST-PASS | /tests/image/test/mochitest/test_bug733553.html | Test 3 lime100x100.svg width not correct - 100 should equal 100 > [...] > 12934 ERROR TEST-UNEXPECTED-FAIL | /tests/image/test/mochitest/test_bug733553.html | Test 4 big.png width not correct - got 40, expected 3000 > 12935 INFO TEST-PASS | /tests/image/test/mochitest/test_bug733553.html | Test 5 animated-gif2.gif width not correct - 40 should equal 40 It was getting the size of the next image in the stream: by the time the test was run, the next image was already there. Best answer here is to stop using big.png in the test; it offers no benefit, plus causes harm (overflows the frame, requiring a bunch of extra work, which makes it take too long). Extending the stream interval even further (already lengthened it in the last revision of the test) isn't worth it when this is the only image in the stream that needs such time. Could probably shorten the interval, but will leave it as is, to be conservative.
Attachment #625541 - Flags: review?(joe)
Comment on attachment 625541 [details] [diff] [review] Stop including big.png in the test, as it can take a bit to decode. No downside, hopefully big upside. Do it!
Attachment #625541 - Flags: review?(joe) → review+
Assignee: nobody → unusualtears
https://hg.mozilla.org/integration/mozilla-inbound/rev/48ec44a4ecea
Flags: in-testsuite+
Keywords: checkin-needed
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/48ec44a4ecea
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://tbpl.mozilla.org/?tree=Try&rev=69ba765bc1e7 My first try push, so hopefully I did it correctly. Increased the stream interval from one to three seconds. Change isn't a risk for other platforms, so only trying the failing one.
The try push looked successful, though if this is intermittent I'm not sure if it's representative?
Attachment #648854 - Flags: review?(joe)
Attachment #648854 - Flags: review?(joe) → review+
Attachment #648854 - Attachment is obsolete: true
Depends on: 785774
Whiteboard: [orange]
Resolving WFM keyword:intermittent-failure bugs last modified >3 months ago, whose whiteboard contains none of: {random,disabled,marked,fuzzy,todo,fails,failing,annotated,time-bomb,leave open} There will inevitably be some false positives; for that (and the bugspam) I apologise. Filter on orangewfm.
Status: REOPENED → RESOLVED
Closed: 13 years ago → 12 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: