785774 - Intermittent test_bug733553.html | | Test 0 red.png width not correct - got 40, expected 1 followed by failures in Test 1, 2, 3, 4, 5 and a | Test timed out.

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Phil Ringnalda (:philor)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=14693991&tree=Mozilla-Inbound
Rev3 Fedora 12 mozilla-inbound debug test mochitests-4/5 on 2012-08-24 22:47:42 PDT for push 772c3eed0cfb
slave: talos-r3-fed-014

12820 ERROR TEST-UNEXPECTED-FAIL | /tests/image/test/mochitest/test_bug733553.html | Test 0 red.png width not correct - got 40, expected 1
12821 ERROR TEST-UNEXPECTED-FAIL | /tests/image/test/mochitest/test_bug733553.html | Test 1 animated-gif2.gif width not correct - got 1, expected 40
12822 ERROR TEST-UNEXPECTED-FAIL | /tests/image/test/mochitest/test_bug733553.html | Test 2 red.png width not correct - got 100, expected 1
12823 ERROR TEST-UNEXPECTED-FAIL | /tests/image/test/mochitest/test_bug733553.html | Test 3 lime100x100.svg width not correct - got 40, expected 100
12824 ERROR TEST-UNEXPECTED-FAIL | /tests/image/test/mochitest/test_bug733553.html | Test 4 animated-gif2.gif width not correct - got 1, expected 40
12825 ERROR TEST-UNEXPECTED-FAIL | /tests/image/test/mochitest/test_bug733553.html | Test 5 red.png width not correct - got 100, expected 1
12826 ERROR TEST-UNEXPECTED-FAIL | /tests/image/test/mochitest/test_bug733553.html | Test timed out.

Comment 1

[Adam]

Attachment: Make multipart test use a signal

I forgot to get the change from bug 756927 landed, but it wouldn't have helped here, and this kills both.  This makes the test signal-based instead of timing-based.

This adds a separate dummy server |bug733553-informant.sjs| to the test that's used to signal the main server to proceed with the next part.

So the test gets a |load| event for the image, checks it, then loads the dummy server which just sets the shared state with the next test part.  

The main server now sends off a part, and holds until it sees the shared state update.  When it has, it sends the next part.

Try push is at:
https://tbpl.mozilla.org/?tree=Try&rev=273a7f91c3d6

Comment 2

[Joe Drew (not getting mail)]

Comment on attachment 655813 [details] [diff] [review]
Make multipart test use a signal

Review of attachment 655813 [details] [diff] [review]:
-----------------------------------------------------------------

Well this is just wonderful.

If you're not positive that it fixes the intermittent orange, you can trigger a pile of repeats of the test by pressing the "+" link/image on your Try tbpl page.

Comment 3

[Adam]

Attachment: Update for checkin

Thanks Joe!

Comment 4

[Adam]

Green try at: https://tbpl.mozilla.org/?tree=Try&rev=273a7f91c3d6

Comment 5

[Ryan VanderMeulen [:RyanVM]]

(In reply to Adam [:hobophobe] from comment #4)
> Green try at: https://tbpl.mozilla.org/?tree=Try&rev=273a7f91c3d6

https://hg.mozilla.org/integration/mozilla-inbound/rev/5d772c765d4e

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5d772c765d4e

Comment 7

[Joe Drew (not getting mail)]

Needed this to push bug 787899's tests cleanly to aurora, so it got to ride along.

remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/d234a1e40780

Comment 8

[Scoobidiver (away)]

Backed out from Aurora: http://hg.mozilla.org/releases/mozilla-aurora/rev/7a03659b943e