Note: There are a few cases of duplicates in user autocompletion which are being worked on.

deleteDatabase should fire a versionchange event with newVersion === null

RESOLVED FIXED in mozilla15

Status

()

Core
DOM: IndexedDB
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: khuey, Assigned: khuey)

Tracking

unspecified
mozilla15
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
Created attachment 625778 [details] [diff] [review]
Patch
Assignee: nobody → khuey
Status: NEW → ASSIGNED
Attachment #625778 - Flags: review?(jonas)
Comment on attachment 625778 [details] [diff] [review]
Patch

Review of attachment 625778 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/indexedDB/test/unit/test_deleteDatabase.js
@@ +53,5 @@
>      ok(event instanceof IDBVersionChangeEvent, "expect a versionchange event");
>      is(event.oldVersion, 10, "oldVersion should be 10");
> +    ok(event.newVersion === null, "newVersion should be null");
> +    ok(!(event.newVersion === undefined), "newVersion should be null");
> +    ok(!(event.newVersion === 0), "newVersion should be null");

just doing ise(event.newVersion, null, "..."); seems enough.
Attachment #625778 - Flags: review?(jonas) → review+
Can't do ise, doesn't exist in xpcshell.

https://hg.mozilla.org/mozilla-central/rev/3b8c17318c3c
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.