757222 - deleteDatabase should fire a versionchange event with newVersion === null

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 625778 [details] [diff] [review]
Patch

Review of attachment 625778 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/indexedDB/test/unit/test_deleteDatabase.js
@@ +53,5 @@
>      ok(event instanceof IDBVersionChangeEvent, "expect a versionchange event");
>      is(event.oldVersion, 10, "oldVersion should be 10");
> +    ok(event.newVersion === null, "newVersion should be null");
> +    ok(!(event.newVersion === undefined), "newVersion should be null");
> +    ok(!(event.newVersion === 0), "newVersion should be null");

just doing ise(event.newVersion, null, "..."); seems enough.

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Can't do ise, doesn't exist in xpcshell.

https://hg.mozilla.org/mozilla-central/rev/3b8c17318c3c