Last Comment Bug 757222 - deleteDatabase should fire a versionchange event with newVersion === null
: deleteDatabase should fire a versionchange event with newVersion === null
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: IndexedDB (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla15
Assigned To: Kyle Huey [:khuey] (khuey@mozilla.com)
:
Mentors:
Depends on:
Blocks: 726378
  Show dependency treegraph
 
Reported: 2012-05-21 14:51 PDT by Kyle Huey [:khuey] (khuey@mozilla.com)
Modified: 2012-05-28 00:58 PDT (History)
1 user (show)
khuey: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (2.28 KB, patch)
2012-05-21 15:06 PDT, Kyle Huey [:khuey] (khuey@mozilla.com)
jonas: review+
Details | Diff | Review

Description Kyle Huey [:khuey] (khuey@mozilla.com) 2012-05-21 14:51:03 PDT

    
Comment 1 Kyle Huey [:khuey] (khuey@mozilla.com) 2012-05-21 15:06:56 PDT
Created attachment 625778 [details] [diff] [review]
Patch
Comment 2 Jonas Sicking (:sicking) PTO Until July 5th 2012-05-22 15:29:11 PDT
Comment on attachment 625778 [details] [diff] [review]
Patch

Review of attachment 625778 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/indexedDB/test/unit/test_deleteDatabase.js
@@ +53,5 @@
>      ok(event instanceof IDBVersionChangeEvent, "expect a versionchange event");
>      is(event.oldVersion, 10, "oldVersion should be 10");
> +    ok(event.newVersion === null, "newVersion should be null");
> +    ok(!(event.newVersion === undefined), "newVersion should be null");
> +    ok(!(event.newVersion === 0), "newVersion should be null");

just doing ise(event.newVersion, null, "..."); seems enough.
Comment 3 Kyle Huey [:khuey] (khuey@mozilla.com) 2012-05-28 00:58:06 PDT
Can't do ise, doesn't exist in xpcshell.

https://hg.mozilla.org/mozilla-central/rev/3b8c17318c3c

Note You need to log in before you can comment on or make changes to this bug.