757295 - Extract newly added locale information from the manifest.

Status: RESOLVED FIXED

(Marketplace Graveyard :: Developer Pages, defect, P4)

Description

[krupa raj[:krupa]]

We already have a cron which checks for changes in the manifest. If we detect new locales in the manifest, we should extract this information and add it to the developer hub.

* We can do this whenever the cron runs or when the user forces a manifest refresh.
* If the developer has added 4 locales out of which one is not supported by Marketplace, we should fail silently.
* Both successful and unsuccessful attempts to add locales should generate an entry in the activity page.

Still to be answered:
* How do we deal with changes to the default locale?
* How do we deal with locales being removed from the manifest?

Marking this [ddn] to get further suggestions from product

Comment 1

[Wil Clouser [:clouserw]]

> * How do we deal with changes to the default locale?

Ignore them because people customize the strings on the marketplace.

> * How do we deal with locales being removed from the manifest?

Ignore that also for now.

Comment 2

[Christopher Van Wiemeersch [:cvan]]

Seems like something Basta might be interested in.

Comment 3

[Matt Basta [:basta]]

(In reply to krupa raj 82[:krupa] from comment #0)
> * How do we deal with changes to the default locale?

To elaborate on what Wil said:

The default_locale element doesn't describe an "intended" locale for the app or a "home" locale. Instead, it describes what language the root attributes of the manifest are written in. So for instance, if the developer has a manifest submitted with a default locale of "en-us" and changes all of the elements in the root to Spanish (and default_locale to "es"), the Spanish version of the app's strings should be updated with the information that's now in the root rather than the english version.

To illustrate, the following two manifests would result in no changes if they were interchanged:

{
  "name": "My App",
  "description": "My elevator pitch goes here",
  "launch_path": "/",
  "icons": {"128": "/img/icon-128.png"},
  "default_locale": "en",
  "locales": {"fr": {"name": "Le App", "description": "Omelet du fromage"}}
}

{
  "name": "Le App",
  "description": "Omelet du fromage",
  "launch_path": "/",
  "icons": {"128": "/img/icon-128.png"},
  "default_locale": "fr",
  "locales": {"en": {"name": "My App", "description": "My elevator pitch goes here"}}
}

Comment 5

[Wil Clouser [:clouserw]]

Rob - Is this a dupe of bug 749813?

Comment 6

[Rob Hudson [:robhudson]]

(In reply to Wil Clouser [:clouserw] from comment #5)
> Rob - Is this a dupe of bug 749813?

It seems subtly different.

Comment 7

[Matt Basta [:basta]]

I think this is done. The code looks like it's doing the right thing (and there have been enough meetings with dbialer to confirm that what we do is what we do).