757339 - No rule to make target `../../gfx/ots/src/libmozots.a', needed by `libgkmedias.a.desc'. Stop.

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Landry Breuil (:gaston)]

This happens once in a while on my buildbot, where make clean is ran if the build succeeds otherwise the objdir is let as-is. It happens on builds that previously failed or not.

objdir/gfx/ots/src contains all the objfiles and libmozots.a.desc but not libmozots.a.

Removing objdir "fixes" it until it happens again. rnewman also saw it on macos.

Such occurences (but i have way more in the backlog, i can dig for all of them)

http://buildbot.rhaalovely.net/builders/mozilla-central-amd64/builds/399/steps/build/logs/stdio
http://buildbot.rhaalovely.net/builders/comm-central-i386/builds/172/steps/build/logs/stdio

Comment 1

[Mike Hommey [:glandium]]

FTR, this comes from .deps/libs being generated at inconvenient times.

Comment 2

[Landry Breuil (:gaston)]

A change in that timeframe probably triggered it for that occurence : https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=fb3036d9b9&tochange=64187d60fa

Comment 3

[Richard Newman [:rnewman]]

This routinely occurs on my Mac as of yesterday, regardless of blowing away objdir/gfx. Next up will be blowing away the entire objdir.

I saved objdir/gfx from my first failed build, if you want a look.

Comment 4

[Mike Hommey [:glandium]]

(In reply to Richard Newman [:rnewman] from comment #3)
> This routinely occurs on my Mac as of yesterday, regardless of blowing away
> objdir/gfx. Next up will be blowing away the entire objdir.
> 
> I saved objdir/gfx from my first failed build, if you want a look.

You need to remove the $objdir/layout/media/.deps/libs file if you want to avoid removing the entire objdir.

Comment 5

[Mike Hommey [:glandium]]

Attachment: Make expandlibs commands generate dependencies like gcc does

This is a more elegant approach to bug 644608, which solves issues with missing files by using the same logic as compilation dependencies (thus using mddepend.pl).
<none>

Comment 6

[Mike Hommey [:glandium]]

Attachment: Make expandlibs commands generate dependencies like gcc does

Changes since last patch:
- safer mkdir
- don't include directories in dependencies
- try to remove as much commands as possible, including wrappers such as distcc or ccache

Comment 7

[Landry Breuil (:gaston)]

The same failure happened when building aurora tonight, so a bit after the last m-c->aurora uplift.

Comment 8

[(not currently active) Ted Mielczarek]

Comment on attachment 626715 [details] [diff] [review]
Make expandlibs commands generate dependencies like gcc does

Review of attachment 626715 [details] [diff] [review]:
-----------------------------------------------------------------

::: config/expandlibs_exec.py
@@ +314,5 @@
> +    if not options.depend:
> +        return
> +    ensureParentDir(options.depend)
> +    with open(options.depend, 'w') as depfile:
> +        print >>depfile, options.target, ':', ' '.join(dep for dep in deps if os.path.isfile(dep) and dep != options.target)

I'm not a big fan of just using commas here. Use a string with formatting instead. Also, print>> is a little weird, maybe just depfile.write()?

::: config/expandlibs_gen.py
@@ +43,5 @@
> +        print >>outfile, generate(args)
> +    if options.depend:
> +        ensureParentDir(options.depend)
> +        with open(options.depend, 'w') as depfile:
> +            print >>depfile, options.output, ':', ' '.join(ExpandLibsDeps(args))

Same as above.

Comment 9

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2d48da1f2bd7

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2d48da1f2bd7

Comment 11

[Philip Chee]

This caused SeaMonkey Bug 763143

Comment 12

[David :Bienvenu]

This has also broken Thunderbird builds, with a similar error, at least on my machine, using pymake on windows. Presumably, similar changes need to be made to comm-central/config/config.mk and rules.mk?