Closed
Bug 766793
Opened 12 years ago
Closed 12 years ago
layout/media not always relinking when things change
Categories
(Firefox Build System :: General, defect)
Tracking
(firefox15 unaffected, firefox16- fixed)
RESOLVED
FIXED
mozilla17
Tracking | Status | |
---|---|---|
firefox15 | --- | unaffected |
firefox16 | - | fixed |
People
(Reporter: bas.schouten, Assigned: khuey)
References
Details
(Whiteboard: [capacity])
Attachments
(1 file)
2.69 KB,
patch
|
ted
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Both me and Nick Cameron have noticed layout/media is not always relinking gkmedias.dll when stuff that is linked in there changes. (Like Azure for example) This can cause unexpected (old) code to be run and linked in, causing all kinds of mysterious bugs. It can also cause newly added symbols not to be found when xul is linking to gkmedias. It's a big problem.
Comment 1•12 years ago
|
||
This was one of the (3-4) causes of bustage today that caused myself and RyanVM to spend about 6 hours of a weekend messing about with retriggers. The changesets in question that landed were: https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=22eea4925efc Examples of the crashes at: https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=a04448be734a Please can someone take a look at this, since it's only going to bite us again (and you can bet during peak coalescing hours :-/). :-)
Severity: critical → blocker
Hardware: x86_64 → x86
Comment 2•12 years ago
|
||
CCing sheriffs who might be affected by this in the future.
Reporter | ||
Comment 3•12 years ago
|
||
Just as a reminder.. this bug is -still- there. This will continue to cause build bustages.
Comment 4•12 years ago
|
||
This bit us again on inbound last night. I have way too little build-system knowledge to know where to start with this, or I'd try and take a look myself :-( Please may someone take a look?
Comment 5•12 years ago
|
||
And again this morning after https://hg.mozilla.org/integration/mozilla-inbound/rev/6229a3b222e4
Comment 6•12 years ago
|
||
And a few more times this afternoon/evening. Every time I have to clobber on all platforms - this is really hurting our infra load at the moment.
Whiteboard: [capacity]
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → khuey
Assignee | ||
Comment 7•12 years ago
|
||
Attachment #654731 -
Flags: review?(ted.mielczarek)
Comment 8•12 years ago
|
||
Comment on attachment 654731 [details] [diff] [review] Patch Ugh.
Attachment #654731 -
Flags: review?(ted.mielczarek) → review+
Comment 9•12 years ago
|
||
(In reply to Ted Mielczarek [:ted] from comment #8) > Comment on attachment 654731 [details] [diff] [review] > Patch > > Ugh. Amazing that it worked at all. And that has been there for, like, ever.
Comment 10•12 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #9) > Amazing that it worked at all. And that has been there for, like, ever. Ah, I'm realizing this was triggered by bug 757339, which means this affects aurora but not beta.
Blocks: 757339
status-firefox15:
--- → unaffected
status-firefox16:
--- → affected
tracking-firefox16:
--- → ?
Comment 11•12 years ago
|
||
Yeah, aurora showed the effects by hitting bug 777755 until I clobbered it.
Comment 12•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ecd18a2ed3ef
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Comment 13•12 years ago
|
||
Comment on attachment 654731 [details] [diff] [review] Patch [Triage Comment] land away to Aurora.
Attachment #654731 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 14•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/4e68f2c7176b
Updated•12 years ago
|
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•