Last Comment Bug 757518 - PGO build gets stuck in a loop on systems where /usr/bin/makedepend is not present
: PGO build gets stuck in a loop on systems where /usr/bin/makedepend is not pr...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: x86_64 Linux
: -- normal (vote)
: mozilla15
Assigned To: Chris Coulson
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-22 10:32 PDT by Chris Coulson
Modified: 2012-05-23 04:51 PDT (History)
2 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Don't get stuck in a loop on systems where /usr/bin/makedepend does not exist (1.18 KB, patch)
2012-05-22 10:32 PDT, Chris Coulson
ted: review+
Details | Diff | Review

Description Chris Coulson 2012-05-22 10:32:45 PDT
Created attachment 626081 [details] [diff] [review]
Don't get stuck in a loop on systems where /usr/bin/makedepend does not exist

A PGO build on a system where /usr/bin/makedepend is not present seems to get stuck in a loop:

MOZ_PGO_INSTRUMENTED=1 OBJDIR=/build/buildd/firefox-13.0~b4+build1/build-tree/mozilla//obj-i686-linux-gnu JARLOG_DIR=/build/buildd/firefox-13.0~b4+build1/build-tree/mozilla//obj-i686-linux-gnu/jarlog/en-US xvfb-run -a /usr/bin/python /build/buildd/firefox-13.0~b4+build1/build-tree/mozilla//obj-i686-linux-gnu/_profile/pgo/profileserver.py 10
args: ['/build/buildd/firefox-13.0~b4+build1/build-tree/mozilla/obj-i686-linux-gnu/dist/firefox/firefox-bin', '-no-remote', '-profile', '/build/buildd/firefox-13.0~b4+build1/build-tree/mozilla/obj-i686-linux-gnu/_profile/pgo/pgoprofile/', 'http://localhost:8888/index.html']
INFO | automation.py | Application pid: 22967
Xlib:  extension "RANDR" missing on display ":99".

(firefox-bin:22967): Gtk-WARNING **: Could not find the icon 'gtk-go-back-ltr'. The 'hicolor' theme
was not found either, perhaps you need to install it.
You can get a copy from:
	http://icon-theme.freedesktop.org/releases
localhost - - [17/May/2012 19:42:37] "GET /index.html HTTP/1.1" 200 -
localhost - - [17/May/2012 19:42:37] "GET /favicon.ico HTTP/1.1" 200 -
localhost - - [17/May/2012 19:42:39] code 404, message File not found
localhost - - [17/May/2012 19:42:39] "GET /safebrowsing-dummy/newkey HTTP/1.1" 404 -
localhost - - [17/May/2012 19:42:40] "GET /blueprint/sample.html HTTP/1.1" 200 -
localhost - - [17/May/2012 19:42:40] "GET /blueprint/screen.css HTTP/1.1" 200 -
localhost - - [17/May/2012 19:42:40] "GET /blueprint/print.css HTTP/1.1" 200 -
localhost - - [17/May/2012 19:42:40] "GET /blueprint/fancytype-screen.css HTTP/1.1" 200 -
localhost - - [17/May/2012 19:42:40] "GET /blueprint/test.jpg HTTP/1.1" 200 -
localhost - - [17/May/2012 19:42:40] "GET /blueprint/valid.png HTTP/1.1" 200 -
localhost - - [17/May/2012 19:42:43] "GET /blueprint/forms.html HTTP/1.1" 200 -
localhost - - [17/May/2012 19:42:44] "GET /blueprint/grid.png HTTP/1.1" 200 -
localhost - - [17/May/2012 19:42:46] "GET /blueprint/grid.html HTTP/1.1" 200 -
localhost - - [17/May/2012 19:42:46] "GET /blueprint/test-small.jpg HTTP/1.1" 200 -
localhost - - [17/May/2012 19:42:49] "GET /blueprint/elements.html HTTP/1.1" 200 -
localhost - - [17/May/2012 19:42:52] "GET /js-input/3d-cube.html HTTP/1.1" 200 -
localhost - - [17/May/2012 19:42:55] "GET /js-input/3d-morph.html HTTP/1.1" 200 -
localhost - - [17/May/2012 19:42:58] "GET /js-input/3d-raytrace.html HTTP/1.1" 200 -
localhost - - [17/May/2012 19:43:01] "GET /js-input/3d-thingy.html HTTP/1.1" 200 -
localhost - - [17/May/2012 19:43:04] "GET /js-input/access-binary-trees.html HTTP/1.1" 200 -
localhost - - [17/May/2012 19:43:07] "GET /js-input/access-fannkuch.html HTTP/1.1" 200 -
localhost - - [17/May/2012 19:43:10] "GET /js-input/access-nbody.html HTTP/1.1" 200 -
localhost - - [17/May/2012 19:43:13] "GET /js-input/access-nsieve.html HTTP/1.1" 200 -
localhost - - [17/May/2012 19:43:16] "GET /js-input/bitops-3bit-bits-in-byte.html HTTP/1.1" 200 -
localhost - - [17/May/2012 19:43:19] "GET /js-input/bitops-bits-in-byte.html HTTP/1.1" 200 -
localhost - - [17/May/2012 19:43:22] "GET /js-input/bitops-bitwise-and.html HTTP/1.1" 200 -
localhost - - [17/May/2012 19:43:25] "GET /js-input/bitops-nsieve-bits.html HTTP/1.1" 200 -
localhost - - [17/May/2012 19:43:28] "GET /js-input/controlflow-recursive.html HTTP/1.1" 200 -
localhost - - [17/May/2012 19:43:31] "GET /js-input/crypto-aes.html HTTP/1.1" 200 -
localhost - - [17/May/2012 19:43:34] "GET /js-input/crypto-md5.html HTTP/1.1" 200 -
localhost - - [17/May/2012 19:43:37] "GET /js-input/crypto-sha1.html HTTP/1.1" 200 -
localhost - - [17/May/2012 19:43:40] "GET /js-input/crypto-otp.html HTTP/1.1" 200 -
localhost - - [17/May/2012 19:43:40] "GET /js-input/key.gif HTTP/1.1" 200 -
localhost - - [17/May/2012 19:43:40] "GET /js-input/valid-xhtml10.png HTTP/1.1" 200 -
localhost - - [17/May/2012 19:43:43] "GET /js-input/date-format-tofte.html HTTP/1.1" 200 -
localhost - - [17/May/2012 19:43:46] "GET /js-input/date-format-xparb.html HTTP/1.1" 200 -
localhost - - [17/May/2012 19:43:49] "GET /js-input/math-cordic.html HTTP/1.1" 200 -
localhost - - [17/May/2012 19:43:52] "GET /js-input/math-partial-sums.html HTTP/1.1" 200 -
localhost - - [17/May/2012 19:43:55] "GET /js-input/math-spectral-norm.html HTTP/1.1" 200 -
localhost - - [17/May/2012 19:43:58] "GET /js-input/regexp-dna.html HTTP/1.1" 200 -
localhost - - [17/May/2012 19:44:01] "GET /js-input/string-base64.html HTTP/1.1" 200 -
localhost - - [17/May/2012 19:44:04] "GET /js-input/string-fasta.html HTTP/1.1" 200 -
localhost - - [17/May/2012 19:44:07] "GET /js-input/string-tagcloud.html HTTP/1.1" 200 -
localhost - - [17/May/2012 19:44:10] "GET /js-input/string-unpack-code.html HTTP/1.1" 200 -
localhost - - [17/May/2012 19:44:13] "GET /js-input/string-validate-input.html HTTP/1.1" 200 -
INFO | automation.py | Application ran for: 0:01:50.960475
INFO | automation.py | Reading PID log: /tmp/tmpiUivpRpidlog
/usr/bin/make -f /build/buildd/firefox-13.0~b4+build1/build-tree/mozilla/client.mk maybe_clobber_profiledbuild
make[3]: Entering directory `/build/buildd/firefox-13.0~b4+build1/build-tree/mozilla'
/usr/bin/make  -C /build/buildd/firefox-13.0~b4+build1/build-tree/mozilla//obj-i686-linux-gnu maybe_clobber_profiledbuild
make[4]: Entering directory `/build/buildd/firefox-13.0~b4+build1/build-tree/mozilla/obj-i686-linux-gnu'
make[5]: Entering directory `/build/buildd/firefox-13.0~b4+build1/build-tree/mozilla/obj-i686-linux-gnu/browser/installer'
rm -f .md  .bak core     Templates.DB package-manifest removed-files ../../dist/firefox-13.0.en-US.linux-i686.tar.bz2 firefox-13.0.en-US.linux-i686.tar.bz2           LOGS TAGS a.out          so_locations _gen _stubs               
rm -f -r _java /no-such-file
make[5]: Leaving directory `/build/buildd/firefox-13.0~b4+build1/build-tree/mozilla/obj-i686-linux-gnu/browser/installer'
rm -f .md  .bak core     Templates.DB mochitest-plain.log mochitest-chrome.log mochitest-a11y.log mochitest-ipcplugins.log reftest.log crashtest.log jstestbrowser.log   firefox-bin        LOGS TAGS a.out          so_locations _gen _stubs         firefox-bin.exp  firefox-bin.lib    
rm -f -r dist _javagen _profile _tests staticlib _java /no-such-file
/usr/bin/make -C config clean
make[5]: Entering directory `/build/buildd/firefox-13.0~b4+build1/build-tree/mozilla/obj-i686-linux-gnu/config'
rm -f .md  .bak core     Templates.DB ../dist/stl_wrappers/sentinel ../config/final-link-comps ../config/final-link-libs ../config/final-link-comp-names buildid /build/buildd/firefox-13.0~b4+build1/build-tree/mozilla/config/*.pyc *.pyc nsinstall  elf-dynstr-gc   LOGS TAGS a.out     host_nsinstall.o host_pathsub.o host_nsinstall.o host_pathsub.o    so_locations _gen _stubs               
rm -f -r .deps _java system_wrappers stl_wrappers /no-such-file
cd /build/buildd/firefox-13.0~b4+build1/build-tree/mozilla/obj-i686-linux-gnu/config/mkdepend; /usr/bin/make clean
/bin/sh: 1: cd: can't cd to /build/buildd/firefox-13.0~b4+build1/build-tree/mozilla/obj-i686-linux-gnu/config/mkdepend
make[6]: Entering directory `/build/buildd/firefox-13.0~b4+build1/build-tree/mozilla/obj-i686-linux-gnu/config'
rm -f .md  .bak core     Templates.DB ../dist/stl_wrappers/sentinel ../config/final-link-comps ../config/final-link-libs ../config/final-link-comp-names buildid /build/buildd/firefox-13.0~b4+build1/build-tree/mozilla/config/*.pyc *.pyc nsinstall  elf-dynstr-gc   LOGS TAGS a.out     host_nsinstall.o host_pathsub.o host_nsinstall.o host_pathsub.o    so_locations _gen _stubs               
rm -f -r .deps _java system_wrappers stl_wrappers /no-such-file
cd /build/buildd/firefox-13.0~b4+build1/build-tree/mozilla/obj-i686-linux-gnu/config/mkdepend; /usr/bin/make clean
/bin/sh: 1: cd: can't cd to /build/buildd/firefox-13.0~b4+build1/build-tree/mozilla/obj-i686-linux-gnu/config/mkdepend
make[7]: Entering directory `/build/buildd/firefox-13.0~b4+build1/build-tree/mozilla/obj-i686-linux-gnu/config'
rm -f .md  .bak core     Templates.DB ../dist/stl_wrappers/sentinel ../config/final-link-comps ../config/final-link-libs ../config/final-link-comp-names buildid /build/buildd/firefox-13.0~b4+build1/build-tree/mozilla/config/*.pyc *.pyc nsinstall  elf-dynstr-gc   LOGS TAGS a.out     host_nsinstall.o host_pathsub.o host_nsinstall.o host_pathsub.o    so_locations _gen _stubs               
rm -f -r .deps _java system_wrappers stl_wrappers /no-such-file
cd /build/buildd/firefox-13.0~b4+build1/build-tree/mozilla/obj-i686-linux-gnu/config/mkdepend; /usr/bin/make clean
/bin/sh: 1: cd: can't cd to /build/buildd/firefox-13.0~b4+build1/build-tree/mozilla/obj-i686-linux-gnu/config/mkdepend
make[8]: Entering directory `/build/buildd/firefox-13.0~b4+build1/build-tree/mozilla/obj-i686-linux-gnu/config'
rm -f .md  .bak core     Templates.DB ../dist/stl_wrappers/sentinel ../config/final-link-comps ../config/final-link-libs ../config/final-link-comp-names buildid /build/buildd/firefox-13.0~b4+build1/build-tree/mozilla/config/*.pyc *.pyc nsinstall  elf-dynstr-gc   LOGS TAGS a.out     host_nsinstall.o host_pathsub.o host_nsinstall.o host_pathsub.o    so_locations _gen _stubs               
rm -f -r .deps _java system_wrappers stl_wrappers /no-such-file
cd /build/buildd/firefox-13.0~b4+build1/build-tree/mozilla/obj-i686-linux-gnu/config/mkdepend; /usr/bin/make clean
/bin/sh: 1: cd: can't cd to /build/buildd/firefox-13.0~b4+build1/build-tree/mozilla/obj-i686-linux-gnu/config/mkdepend
make[9]: Entering directory `/build/buildd/firefox-13.0~b4+build1/build-tree/mozilla/obj-i686-linux-gnu/config'
rm -f .md  .bak core     Templates.DB ../dist/stl_wrappers/sentinel ../config/final-link-comps ../config/final-link-libs ../config/final-link-comp-names buildid /build/buildd/firefox-13.0~b4+build1/build-tree/mozilla/config/*.pyc *.pyc nsinstall  elf-dynstr-gc   LOGS TAGS a.out     host_nsinstall.o host_pathsub.o host_nsinstall.o host_pathsub.o    so_locations _gen _stubs               
rm -f -r .deps _java system_wrappers stl_wrappers /no-such-file
cd /build/buildd/firefox-13.0~b4+build1/build-tree/mozilla/obj-i686-linux-gnu/config/mkdepend; /usr/bin/make clean
/bin/sh: 1: cd: can't cd to /build/buildd/firefox-13.0~b4+build1/build-tree/mozilla/obj-i686-linux-gnu/config/mkdepend
make[10]: Entering directory `/build/buildd/firefox-13.0~b4+build1/build-tree/mozilla/obj-i686-linux-gnu/config'
rm -f .md  .bak core     Templates.DB ../dist/stl_wrappers/sentinel ../config/final-link-comps ../config/final-link-libs ../config/final-link-comp-names buildid /build/buildd/firefox-13.0~b4+build1/build-tree/mozilla/config/*.pyc *.pyc nsinstall  elf-dynstr-gc   LOGS TAGS a.out     host_nsinstall.o host_pathsub.o host_nsinstall.o host_pathsub.o    so_locations _gen _stubs               
rm -f -r .deps _java system_wrappers stl_wrappers /no-such-file
cd /build/buildd/firefox-13.0~b4+build1/build-tree/mozilla/obj-i686-linux-gnu/config/mkdepend; /usr/bin/make clean
/bin/sh: 1: cd: can't cd to /build/buildd/firefox-13.0~b4+build1/build-tree/mozilla/obj-i686-linux-gnu/config/mkdepend
make[11]: Entering directory `/build/buildd/firefox-13.0~b4+build1/build-tree/mozilla/obj-i686-linux-gnu/config'
rm -f .md  .bak core     Templates.DB ../dist/stl_wrappers/sentinel ../config/final-link-comps ../config/final-link-libs ../config/final-link-comp-names buildid /build/buildd/firefox-13.0~b4+build1/build-tree/mozilla/config/*.pyc *.pyc nsinstall  elf-dynstr-gc   LOGS TAGS a.out     host_nsinstall.o host_pathsub.o host_nsinstall.o host_pathsub.o    so_locations _gen _stubs               
rm -f -r .deps _java system_wrappers stl_wrappers /no-such-file
cd /build/buildd/firefox-13.0~b4+build1/build-tree/mozilla/obj-i686-linux-gnu/config/mkdepend; /usr/bin/make clean
/bin/sh: 1: cd: can't cd to /build/buildd/firefox-13.0~b4+build1/build-tree/mozilla/obj-i686-linux-gnu/config/mkdepend

...and this seems to continue forever.

(Note, obj-i686-linux-gnu/config/mkdepend really doesn't exist in this build)
Comment 1 Ted Mielczarek [:ted.mielczarek] 2012-05-22 10:36:17 PDT
previously filed as bug 717947, I think the right fix here is bug 740854 but I haven't convinced anyone to fix that for me yet.
Comment 2 Chris Coulson 2012-05-22 10:36:50 PDT
Oops, sorry. You got there before me :)
Comment 3 Chris Coulson 2012-05-22 10:38:48 PDT
Hmmm, I'm not sure how to cancel the review now.

I could probably be convinced to fix bug 740854
Comment 4 Ted Mielczarek [:ted.mielczarek] 2012-05-22 10:41:13 PDT
Comment on attachment 626081 [details] [diff] [review]
Don't get stuck in a loop on systems where /usr/bin/makedepend does not exist

This is simple enough that I'd just take it. I'd prefer the other bug to get fixed, but no sense in leaving this annoyance in here.
Comment 5 Chris Coulson 2012-05-22 13:54:47 PDT
Thanks! I might take a look later on at the other bug too
Comment 6 Ryan VanderMeulen [:RyanVM] 2012-05-22 17:40:57 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/5814957f9225
Comment 7 Ed Morley [:emorley] 2012-05-23 04:51:51 PDT
https://hg.mozilla.org/mozilla-central/rev/5814957f9225

Note You need to log in before you can comment on or make changes to this bug.