757678 - Set IndexedDB permission settings during installation

Status: VERIFIED FIXED

(Firefox Graveyard :: Webapp Runtime, defect, P1)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

While setting up the profile for the XULRunner app, we should set the appropriate settings in the permissions manager to grant the app unlimited access to IndexedDB.

Specifically, the two permissions that should be set are "indexedDB" and "indexedDB-unlimited". They should both be set to nsIPermissionManager.ALLOW_ACTION for the origin of the app.

Comment 1

[Jason Smith [:jsmith]]

Jonas - What's the priority for getting this implemented? Should this block the first release of the webapp runtime? Is it high priority? Nice to have?

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

That's not my decision, but rather the webapps drivers.

Personally I think it's a blocker given the low cost to high value ratio.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

If a topapp was running into this issue, I'd make it a blocker.  Otherwise, it's "merely" a very very very much want!

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Fabrice, didn't you already do this? Or did you do some other settings but not this one?

Comment 5

[[:fabrice] Fabrice Desré]

(In reply to Jonas Sicking (:sicking) from comment #4)
> Fabrice, didn't you already do this? Or did you do some other settings but
> not this one?

We do that with a hack in b2g.js only. We still need to do it cleanly at the end of the install process.

Comment 6

[Jason Smith [:jsmith]]

Reproducible test case for this:

1. Load https://touch.betfair.com/ in the web runtime

Expected - app should finish loading and allow indexed DB by default without a prompt

Actual - app gets stuck during load

Comment 7

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: sets permissions

Comment 8

[:Felipe Gomes (needinfo for replies!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/08d44c70e1cb

Comment 9

[Jason Smith [:jsmith]]

comment 6 I believe should allow us to verify this fix

Comment 10

[Ryan VanderMeulen [:RyanVM][PTO June 24-28]]

https://hg.mozilla.org/mozilla-central/rev/08d44c70e1cb

Comment 11

[Jason Smith [:jsmith]]

comment 6 actually will not verify this bug, as it's related to app cache. Need to find another way to do it.

Comment 12

[Jason Smith [:jsmith]]

What's the easiest way to verify this bug such that it demonstrates unlimited use of indexed DB? Is there a good example of a top app that does this? An app someone else built? Or should I create my own here?

Comment 13

[Jason Smith [:jsmith]]

(In reply to Jason Smith [:jsmith] from comment #12)
> What's the easiest way to verify this bug such that it demonstrates
> unlimited use of indexed DB? Is there a good example of a top app that does
> this? An app someone else built? Or should I create my own here?

Found a way to test this. I used Marco's app for indexed DB and checked if anything launched, but it failed for the web runtime - https://developer.mozilla.org/en-US/demosdetail/elibri/launch. Verification of this is blocked by bug 767807.

Comment 14

[Jason Smith [:jsmith]]

Actually I wasn't right, this is possible to verify. I just have to do the testing on the origin of the app.