Last Comment Bug 757678 - Set IndexedDB permission settings during installation
: Set IndexedDB permission settings during installation
Status: VERIFIED FIXED
[qa!]
:
Product: Firefox Graveyard
Classification: Graveyard
Component: Webapp Runtime (show other bugs)
: unspecified
: All All
: P1 normal
: Firefox 16
Assigned To: Myk Melez [:myk] [@mykmelez]
: Jason Smith [:jsmith]
:
Mentors:
Depends on: 767807
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-22 17:40 PDT by Jonas Sicking (:sicking) No longer reading bugmail consistently
Modified: 2016-03-21 12:39 PDT (History)
7 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch v1: sets permissions (695 bytes, patch)
2012-06-21 17:25 PDT, Myk Melez [:myk] [@mykmelez]
felipc: review+
Details | Diff | Splinter Review

Description Jonas Sicking (:sicking) No longer reading bugmail consistently 2012-05-22 17:40:48 PDT
While setting up the profile for the XULRunner app, we should set the appropriate settings in the permissions manager to grant the app unlimited access to IndexedDB.

Specifically, the two permissions that should be set are "indexedDB" and "indexedDB-unlimited". They should both be set to nsIPermissionManager.ALLOW_ACTION for the origin of the app.
Comment 1 Jason Smith [:jsmith] 2012-05-22 17:45:47 PDT
Jonas - What's the priority for getting this implemented? Should this block the first release of the webapp runtime? Is it high priority? Nice to have?
Comment 2 Jonas Sicking (:sicking) No longer reading bugmail consistently 2012-05-22 18:08:58 PDT
That's not my decision, but rather the webapps drivers.

Personally I think it's a blocker given the low cost to high value ratio.
Comment 3 Myk Melez [:myk] [@mykmelez] 2012-05-25 16:31:15 PDT
If a topapp was running into this issue, I'd make it a blocker.  Otherwise, it's "merely" a very very very much want!
Comment 4 Jonas Sicking (:sicking) No longer reading bugmail consistently 2012-06-06 17:53:31 PDT
Fabrice, didn't you already do this? Or did you do some other settings but not this one?
Comment 5 [:fabrice] Fabrice Desré 2012-06-06 18:00:19 PDT
(In reply to Jonas Sicking (:sicking) from comment #4)
> Fabrice, didn't you already do this? Or did you do some other settings but
> not this one?

We do that with a hack in b2g.js only. We still need to do it cleanly at the end of the install process.
Comment 6 Jason Smith [:jsmith] 2012-06-15 11:15:29 PDT
Reproducible test case for this:

1. Load https://touch.betfair.com/ in the web runtime

Expected - app should finish loading and allow indexed DB by default without a prompt

Actual - app gets stuck during load
Comment 7 Myk Melez [:myk] [@mykmelez] 2012-06-21 17:25:34 PDT
Created attachment 635536 [details] [diff] [review]
patch v1: sets permissions
Comment 8 :Felipe Gomes (needinfo me!) 2012-06-22 15:21:10 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/08d44c70e1cb
Comment 9 Jason Smith [:jsmith] 2012-06-22 15:25:38 PDT
comment 6 I believe should allow us to verify this fix
Comment 10 Ryan VanderMeulen [:RyanVM] 2012-06-23 05:44:30 PDT
https://hg.mozilla.org/mozilla-central/rev/08d44c70e1cb
Comment 11 Jason Smith [:jsmith] 2012-06-24 09:21:51 PDT
comment 6 actually will not verify this bug, as it's related to app cache. Need to find another way to do it.
Comment 12 Jason Smith [:jsmith] 2012-06-26 18:12:17 PDT
What's the easiest way to verify this bug such that it demonstrates unlimited use of indexed DB? Is there a good example of a top app that does this? An app someone else built? Or should I create my own here?
Comment 13 Jason Smith [:jsmith] 2012-06-27 17:03:07 PDT
(In reply to Jason Smith [:jsmith] from comment #12)
> What's the easiest way to verify this bug such that it demonstrates
> unlimited use of indexed DB? Is there a good example of a top app that does
> this? An app someone else built? Or should I create my own here?

Found a way to test this. I used Marco's app for indexed DB and checked if anything launched, but it failed for the web runtime - https://developer.mozilla.org/en-US/demosdetail/elibri/launch. Verification of this is blocked by bug 767807.
Comment 14 Jason Smith [:jsmith] 2012-07-12 15:14:32 PDT
Actually I wasn't right, this is possible to verify. I just have to do the testing on the origin of the app.

Note You need to log in before you can comment on or make changes to this bug.