757755 - The reftest suite appears to be downloading and staging updates on test slaves

Status: RESOLVED FIXED

(Testing :: Reftest, defect)

Description

[Phil Ringnalda (:philor)]

See, for instance, https://tbpl.mozilla.org/php/getParsedLog.php?id=11976410&tree=Firefox failing to start up a mochitest run on talos-r3-w7-056 with a screenshot of the dialog saying that "The update could not be installed." or https://tbpl.mozilla.org/php/getParsedLog.php?id=11954398&tree=Mozilla-Inbound with talos-r3-xp-016 saying the same thing.

From a cursory late-night thought and brief look, I'd say that while mochitests are not downloading updates, because http://mxr.mozilla.org/mozilla-central/source/build/automation.py.in#333 sets the prefs, other suites do download and stage them, and then... mochitests fail because they've set the pref? other suites don't fail, but are actually running tests on the nightly build that they managed to update to, rather than the build they were supposed to test?

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Comment 3

[(no longer active)]

Pushed the patch to the Oak branch: https://tbpl.mozilla.org/?tree=Oak&rev=fb85cfab3829

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 626605 [details] [diff] [review]
Patch (v1)

r=dbaron, if you honor the comment that's just out of diff context:

     * If you change these, please adjust them in the bootstrap.js function·
     * setDefaultPrefs().  These are duplicated there so we can have a·
     * restartless addon for reftest on native Android.
     *
     * FIXME: These should be in only one place.·

Comment 5

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/87ee97bd5db7

Comment 6

[Phil Ringnalda (:philor)]

https://github.com/mozilla/addon-sdk/blob/master/python-lib/cuddlefish/prefs.py

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/87ee97bd5db7