757829 - UrlPoller doesn't poll win32_signing_buildN.log for unsigned Thunderbird releases

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect, P2)

Description

[Rail Aliiev [:rail]]

... because of "if releaseConfig['productName'] == 'firefox':"

Comment 1

[Rail Aliiev [:rail]]

Attachment: get rid of productName

* the idea is to use some patterns, like platform names instead of productName
* $ grep -P '(fennec|firefox|thunderbird)' process/release.py |wc -l
  0
* one of the hunks is more readable if applied and git/hg diffed with -b parameter
* to be tested in staging
* configs diff incoming

Comment 2

[Rail Aliiev [:rail]]

Attachment: configs

Comment 3

[Aki Sasaki (not active)]

Comment on attachment 626493 [details] [diff] [review]
get rid of productName

I can see the hasAndroidPlatform stuff becoming ugly if we start building non-Android Fennec platforms, but since I don't know what form that will take, we probably shouldn't optimize for that now.

I wish there were a simple way to handle this via config rather than hardcoding platform behavior, but I don't think this is worse than keying off the product name.

Comment 4

[Rail Aliiev [:rail]]

(In reply to Aki Sasaki [:aki] from comment #3)
> I wish there were a simple way to handle this via config rather than
> hardcoding platform behavior,

I thought about using something like releaseConfig['workflowType'] = 'firefox'/'fennec', but it also looks ugly :/

Comment 5

[Rail Aliiev [:rail]]

Attachment: tools: use manuallySignedPlatforms

Comment 6

[Rail Aliiev [:rail]]

Attachment: configs

Comment 7

[Rail Aliiev [:rail]]

Attachment: get rid of productName

I tested the patches in staging. So far they look good. I'm still going to run a couple of releases to be sure before I land them.

Comment 8

[Rail Aliiev [:rail]]

(In reply to Rail Aliiev [:rail] from comment #7)
> I tested the patches in staging. So far they look good. I'm still going to
> run a couple of releases to be sure before I land them.

Overnight release builds worked fine for Firefox and Fennec. I think we're safe to proceed with the patches if the approach looks OK to you.

Comment 9

[Rail Aliiev [:rail]]

Comment on attachment 627264 [details] [diff] [review]
configs

http://hg.mozilla.org/build/buildbot-configs/rev/c8feab772b4b

Comment 10

[Rail Aliiev [:rail]]

Comment on attachment 627265 [details] [diff] [review]
get rid of productName

http://hg.mozilla.org/build/buildbotcustom/rev/c72cf730b9e8

Comment 11

[Rail Aliiev [:rail]]

Comment on attachment 627263 [details] [diff] [review]
tools: use manuallySignedPlatforms

http://hg.mozilla.org/build/tools/rev/abb6ddb7ab70

Comment 12

[Rail Aliiev [:rail]]

I removed --create-contri-dirs for some unknown reason...
r=jhopkins on IRC
http://hg.mozilla.org/build/buildbotcustom/rev/6995edbed36d