add in-tree mozconfigs for android/armv6 and android/x86

RESOLVED FIXED in mozilla15

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ted, Assigned: ted)

Tracking

Trunk
mozilla15
All
Android
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
We should have mozconfigs in-tree for these to make things easy.
(Assignee)

Updated

5 years ago
Assignee: nobody → ted.mielczarek
(Assignee)

Comment 1

5 years ago
Created attachment 626508 [details] [diff] [review]
mozconfigs for android-armv6 and android-x86

This patch just copies the existing android mozconfigs and tweaks them. I haven't tried the armv6 one, but it ought to work. (Should be able to push it to try and see.) I've built with the x86 one locally (with a few well-placed symlinks to get /tools in order), but it fails on try because of bug 756816.

r?catlee on the directory layout, r?glandium on the mozconfig contents.
Attachment #626508 - Flags: review?(mh+mozilla)
Attachment #626508 - Flags: review?(catlee)
Comment on attachment 626508 [details] [diff] [review]
mozconfigs for android-armv6 and android-x86

Review of attachment 626508 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/config/mozconfigs/android/debug
@@ +5,5 @@
>  # Build Fennec
>  ac_add_options --enable-application=mobile/android
>  
>  # Android
>  ac_add_options --target=arm-linux-androideabi

Probably makes no difference, but I've always been using i686-linux-android.

@@ +11,5 @@
>  ac_add_options --with-endian=little
>  ac_add_options --with-android-ndk="/tools/android-ndk-r5c"
>  ac_add_options --with-android-sdk="/tools/android-sdk-r15/platforms/android-14"
>  ac_add_options --with-android-tools="/tools/android-sdk-r15/tools"
>  ac_add_options --with-android-toolchain=/tools/android-ndk-r5c/toolchains/arm-linux-androideabi-4.4.3/prebuilt/linux-x86

You should start from the new android mozconfigs (after bug 751265). Most of this is unneeded.
Attachment #626508 - Flags: review?(mh+mozilla) → review-
(Assignee)

Comment 3

5 years ago
(In reply to Mike Hommey [:glandium] from comment #2)
> Comment on attachment 626508 [details] [diff] [review]
> mozconfigs for android-armv6 and android-x86
> 
> Review of attachment 626508 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mobile/android/config/mozconfigs/android/debug
> @@ +5,5 @@
> >  # Build Fennec
> >  ac_add_options --enable-application=mobile/android
> >  
> >  # Android
> >  ac_add_options --target=arm-linux-androideabi
> 
> Probably makes no difference, but I've always been using i686-linux-android.

Presumably you meant to make that comment on the x86 mozconfig, not the armv6 one?

> You should start from the new android mozconfigs (after bug 751265). Most of
> this is unneeded.

Ok, thanks.
(Assignee)

Updated

5 years ago
Depends on: 751265
(In reply to Ted Mielczarek [:ted] from comment #3)
> Presumably you meant to make that comment on the x86 mozconfig, not the
> armv6 one?

indeed, although i think i really did, and i wouldn't be surprised that splinter review was just confused by the file copies.
Comment on attachment 626508 [details] [diff] [review]
mozconfigs for android-armv6 and android-x86

Review of attachment 626508 [details] [diff] [review]:
-----------------------------------------------------------------

directory structure looks fine
Attachment #626508 - Flags: review?(catlee) → review+
(Assignee)

Comment 6

5 years ago
Created attachment 626886 [details] [diff] [review]
mozconfigs for android-armv6 and android-x86

Rebased on top of bug 751265.
Attachment #626886 - Flags: review?(mh+mozilla)
(Assignee)

Updated

5 years ago
Attachment #626508 - Attachment is obsolete: true
Comment on attachment 626886 [details] [diff] [review]
mozconfigs for android-armv6 and android-x86

Review of attachment 626886 [details] [diff] [review]:
-----------------------------------------------------------------

Please remove that extra line you add to mobile/android/config/mozconfigs/android-x86/nightly.

(FWIW, Splinter review *is* confused by the copied files)
Attachment #626886 - Flags: review?(mh+mozilla) → review+
(Assignee)

Comment 8

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad71b887061f
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/ad71b887061f
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Comment on attachment 626886 [details] [diff] [review]
mozconfigs for android-armv6 and android-x86

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: can't build ARMv6 for Fx15
Testing completed (on m-c, etc.): landed on m-c when it was Fx16
Risk to taking this patch (and alternatives if risky): 
String or UUID changes made by this patch:
Attachment #626886 - Flags: approval-mozilla-beta?
(Assignee)

Comment 11

5 years ago
There's no risk to these patches, they're mozconfigs for alternate build configurations. They have no impact on the existing build configurations.
Comment on attachment 626886 [details] [diff] [review]
mozconfigs for android-armv6 and android-x86

no risk, mozconfigs only - approving.
Attachment #626886 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.