758141 - implement the component search facility from the bmo extension in the guided entry form.

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, enhancement, P2)

Description

[:glob ✱]

implement the component search facility from the bmo extension (bug 747193) in the guided entry form.

Comment 1

[:glob ✱]

Attachment: patch v1

this patch uses the web service provided by the bmo ext if it's installed.
also had to carry the component if selected from the autocomplete menu through to the final step.

Comment 2

[David Lawrence [:dkl]]

Comment on attachment 627688 [details] [diff] [review]
patch v1

Review of attachment 627688 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good overall with one minor suggestion that can be fixed on checkin. r=dkl

Thought: what if I were to break out the HTML portion of prod_comp_search in choose-product.html.tmpl into it's own template. Would we both be able to share that if it were generic enough? If not worth the effort we can just maintain the duplication for now.

dkl

::: extensions/GuidedBugEntry/template/en/default/guided/guided.html.tmpl
@@ +19,3 @@
>     style_urls = [ 'extensions/GuidedBugEntry/web/style/guided.css',
>                    'js/yui/assets/skins/sam/container.css' ]
> +   yui = [ 'history', 'datatable', 'container', 'autocomplete' ]

Do the same with 'yui' a you did with javascript_urls where you push 'autocomplete' on to the list if BMO is true.

::: extensions/GuidedBugEntry/web/js/guided.js
@@ +100,4 @@
>  
> +  onInit: function() {
> +    // BMO only
> +    if (YAHOO.bugzilla.prodCompSearch.autoComplete) {

I will add the throbber to my code as well in choose-product.html.tmpl as I like the one you added. When I do I will remove this as well.

Comment 3

[:glob ✱]

(In reply to David Lawrence [:dkl] from comment #2)
> Thought: what if I were to break out the HTML portion of prod_comp_search in
> choose-product.html.tmpl into it's own template. Would we both be able to
> share that if it were generic enough? If not worth the effort we can just
> maintain the duplication for now.

i don't think it's worth the effort right now.

Committing to: bzr+ssh://[e-mail]/bmo/4.0/
modified extensions/BMO/template/en/default/global/choose-product.html.tmpl
modified extensions/BMO/web/js/choose_product.js
modified extensions/GuidedBugEntry/Config.pm
modified extensions/GuidedBugEntry/Extension.pm
modified extensions/GuidedBugEntry/template/en/default/guided/guided.html.tmpl
modified extensions/GuidedBugEntry/template/en/default/guided/products.html.tmpl
modified extensions/GuidedBugEntry/template/en/default/pages/guided_products.js.tmpl
modified extensions/GuidedBugEntry/web/js/guided.js
modified extensions/GuidedBugEntry/web/js/products.js
modified extensions/GuidedBugEntry/web/style/guided.css
Committed revision 8197.

Committing to: bzr+ssh://[e-mail]/bmo/4.2/
modified extensions/BMO/template/en/default/global/choose-product.html.tmpl
modified extensions/BMO/web/js/choose_product.js
modified extensions/GuidedBugEntry/Config.pm
modified extensions/GuidedBugEntry/Extension.pm
modified extensions/GuidedBugEntry/template/en/default/guided/guided.html.tmpl
modified extensions/GuidedBugEntry/template/en/default/guided/products.html.tmpl
modified extensions/GuidedBugEntry/template/en/default/pages/guided_products.js.tmpl
modified extensions/GuidedBugEntry/web/js/guided.js
modified extensions/GuidedBugEntry/web/js/products.js
modified extensions/GuidedBugEntry/web/style/guided.css
Committed revision 8176.