Implement the component search facility from the bmo extension on the browse (describe components) page.

RESOLVED FIXED

Status

()

bugzilla.mozilla.org
User Interface
--
enhancement
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: MattN, Assigned: dkl)

Tracking

Production

Details

Attachments

(1 attachment, 1 obsolete attachment)

Implement the component search facility from the bmo extension (bug 747193) on the browse (aka. describe components) page.  It would make it much faster to get to a specific component to browse.
(Assignee)

Comment 1

6 years ago
I just thought of a cool way to do this. Patch coming.

dkl
Assignee: nobody → dkl
Status: NEW → ASSIGNED
(Assignee)

Comment 2

6 years ago
Created attachment 640104 [details] [diff] [review]
Patch to allow product component search for describecomponents.cgi (v1)

This refactors choose-product.html.tmpl and prod-comp-search.html.tmpl even further and also makes some changes to the core reports/components.html to support highlighting and component anchors. The latter changes will need to be pushed upstream but I feel they will be useful there.

dkl
Attachment #640104 - Flags: review?(glob)
Comment on attachment 640104 [details] [diff] [review]
Patch to allow product component search for describecomponents.cgi (v1)

this mostly looks good.


this triggers a massive torrent of "use of unitialized" warnings once you've selected a product.

>     <td rowspan="2" class="component_name">
>+      <a name="[% comp.name FILTER html %]">
>       <a href="buglist.cgi?product=
>                [%- product.name FILTER url_quote %]&amp;component=
>                [%- comp.name FILTER url_quote %]&amp;resolution=---">
>@@ -96,9 +101,10 @@
>       </td>

add the name attribute to the existing <a> element, rather than creating a new (unclosed) element.

>+  [% Hook.process('component') %]

this hook isn't used (looks like it's causing the unitialized warnings).
Attachment #640104 - Flags: review?(glob) → review-
(Assignee)

Comment 4

6 years ago
Created attachment 640604 [details] [diff] [review]
Patch to allow product component search for describecomponents.cgi (v2)
Attachment #640104 - Attachment is obsolete: true
Attachment #640604 - Flags: review?(glob)
Comment on attachment 640604 [details] [diff] [review]
Patch to allow product component search for describecomponents.cgi (v2)

r=glob

nice :)
Attachment #640604 - Flags: review?(glob) → review+
(Assignee)

Comment 6

6 years ago
Thanks

Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bmo/4.0
modified template/en/default/reports/components.html.tmpl
modified skins/standard/reports.css
modified describecomponents.cgi
modified extensions/BMO/template/en/default/global/choose-product.html.tmpl
modified extensions/BMO/template/en/default/global/prod-comp-search.html.tmpl
Committed revision 8235.

Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bmo/4.2
modified template/en/default/reports/components.html.tmpl
modified skins/standard/reports.css                                       
modified describecomponents.cgi
modified extensions/BMO/template/en/default/global/choose-product.html.tmpl
modified extensions/BMO/template/en/default/global/prod-comp-search.html.tmpl      
Committed revision 8238
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.