Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Add a new telemetry histogram for the reason preload is activated

VERIFIED FIXED in mozilla15

Status

()

Core
Widget: Win32
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: bbondy, Assigned: bbondy)

Tracking

12 Branch
mozilla15
x86_64
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa!])

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

5 years ago
We should add a new telemetry histogram in Windows for the reason preload is being used.  Values should be 0 for none, 1 for preload because service disabled prefetch, and 2 because ioCounters.ReadOperationCount is 0.
(Assignee)

Updated

5 years ago
Component: Application Update → Widget: Win32
Product: Toolkit → Core
QA Contact: application.update → win32
(Assignee)

Comment 1

5 years ago
Created attachment 626792 [details] [diff] [review]
Patch v1.
Attachment #626792 - Flags: review?(taras.mozilla)

Comment 2

5 years ago
Comment on attachment 626792 [details] [diff] [review]
Patch v1.

thanks
Attachment #626792 - Flags: review?(taras.mozilla) → review+
(Assignee)

Comment 3

5 years ago
I just noticed when I did a full build that I was getting a compiling error. 
I think I need to update the definition of the histogram from 
> ...0, 2, 3...

to:
> 1, 2, 

Please confirm and I'll attach a new patch and carry forward the r+.
(Assignee)

Comment 4

5 years ago
Created attachment 626862 [details] [diff] [review]
Patch v2 - Base patch for adding telemetry for preload

Updated to 1,2,3 as per IRC, carrying forward r+.
Attachment #626792 - Attachment is obsolete: true
Attachment #626862 - Flags: review+
(Assignee)

Comment 5

5 years ago
Created attachment 627236 [details] [diff] [review]
Patch v1 - Better prefetch cleared detection for telemetry

This patch will help us get better telemetry data. 
It will more deterministically detect when we should mark the prefetch cleared flag that we use in telemetry.
Attachment #627236 - Flags: review?(taras.mozilla)
(Assignee)

Comment 6

5 years ago
This patch will also improve the message in the log for already cleared prefetch file (it won't say access denied anymore for those files)

Updated

5 years ago
Attachment #627236 - Flags: review?(taras.mozilla) → review+
(Assignee)

Comment 7

5 years ago
Thanks for the quick reviews :)
(Assignee)

Updated

5 years ago
Attachment #626862 - Attachment description: Patch v2. → Patch v2 - Base patch for adding telemetry for preload
(Assignee)

Comment 8

5 years ago
http://hg.mozilla.org/mozilla-central/rev/93018b4bf4da
http://hg.mozilla.org/mozilla-central/rev/de230f4a91f7
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15

Updated

5 years ago
Whiteboard: [qa+]
Checking the telemetry histogram for STARTUP_USING_PRELOAD, I see that the histogram has been populated with 44815 submissions with the following distribution:

- 0: 56.95% (none)
- 1: 23.16% (preload since service disabled prefetch)
- 2: 19.88% (ioCounters.ReadOperationCount = 0)

I believe this verifies if we're getting data, correct?

One clarification question - What exactly is this distribution telling us? Trying to understand how to interpret this histogram.
(Assignee)

Comment 10

5 years ago
> I believe this verifies if we're getting data, correct?

Correct.


> One clarification question - What exactly is this distribution telling us? 
> Trying to understand how to interpret this histogram.

1 tells us that only 23% of the users that have telemetry enabled have a fully cleared prefetch.  Keep in mind that x64 builds don't have a service to clear prefetch with and XP users won't clear on update.  It jumps to 40% on Aurora by the way.

Updated

5 years ago
Status: RESOLVED → VERIFIED
Whiteboard: [qa+] → [qa!]
(In reply to Brian R. Bondy [:bbondy] from comment #10)
> 1 tells us that only 23% of the users that have telemetry enabled have a
> fully cleared prefetch.  Keep in mind that x64 builds don't have a service
> to clear prefetch with and XP users won't clear on update.  It jumps to 40%
> on Aurora by the way.

Although Aurora has a much smaller sample set (219) and I'm not sure this makes sense to see this on Aurora, given that this patch landed on 5/27, but there's data in this pool from 5/17 and on.

The nightly pool has a similar issue, as I'm seeing submissions included in here from 5/9 and on. Is something not right here?
Or maybe I'm interpreting the graph for "submissions by date" incorrectly.
(In reply to Jason Smith [:jsmith] from comment #12)
> Or maybe I'm interpreting the graph for "submissions by date" incorrectly.

Actually, I get the feeling this is a problem in that particular graph, cause the graph below that by platform ID appears to be as one would expect (6/1 and on).
(In reply to Jason Smith [:jsmith] from comment #13)
> (In reply to Jason Smith [:jsmith] from comment #12)
> > Or maybe I'm interpreting the graph for "submissions by date" incorrectly.
> 
> Actually, I get the feeling this is a problem in that particular graph,
> cause the graph below that by platform ID appears to be as one would expect
> (6/1 and on).

Confirmed this is a problem with the actual graph.
You need to log in before you can comment on or make changes to this bug.