The default bug view has changed. See this FAQ.

IonMonkey: Rename forbidOsr and use it when calling functions directly

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
I noticed this a few days ago on some crypto benchmark. The following script will bailout every time we call f:

function f(x) {
    return x >>> 0;
}
for (var i=0; i<200; i++) {
    f(Math.pow(2, 31));
}

Eventually, we should fix this by adding a double/OOL path or something for >>>. However, in the meantime we should give up after bailing out a few times (and there are no type changes). We do this already when we enter via OSR, but we should also do this for non-OSR code.
(Assignee)

Comment 1

5 years ago
Created attachment 627934 [details] [diff] [review]
Patch

Renames forbidOsr to bailoutExpected (better name welcome), and use it also for non-OSR code.
Attachment #627934 - Flags: review?(dvander)
Attachment #627934 - Flags: review?(dvander) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/projects/ionmonkey/rev/d28bcb515936
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.