Only show prompt after 50mb of quota was reached

RESOLVED FIXED in mozilla16

Status

()

Core
DOM: IndexedDB
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: (dormant account), Assigned: Ben Turner (not reading bugmail, use the needinfo flag!))

Tracking

(Depends on: 1 bug, Blocks: 1 bug)

unspecified
mozilla16
x86_64
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

5 years ago
bug 742822 will make indexeddb less persistent. We should proactively get rid of the prompt so web developers can start using indexeddb(and drop dom storage) while we wrap up the quota code.
Blocks: 726378
We should definitely keep this option in mind in order to enable unprefixing IndexedDB. Ideally we would implement the new storage policy of not storing things permanently, but if this is the only thing standing between us and unprefixing, then this seems like a viable short-term fix.

Comment 2

5 years ago
Jonas, should I fix this bug first ?

Comment 3

5 years ago
Jonas agreed on IRC
Assignee: nobody → Jan.Varga
Status: NEW → ASSIGNED
Created attachment 638104 [details] [diff] [review]
Patch

This keeps it at 50mb like we agreed, and it fixes the UI to be sane (it does nearly the same thing as the fullscreen permission UI). Seems like a fair compromise.
Assignee: Jan.Varga → bent.mozilla
Attachment #638104 - Flags: review?(jonas)
Created attachment 638105 [details] [diff] [review]
Patch

Clearly that was not the right patch.
Attachment #638104 - Attachment is obsolete: true
Attachment #638104 - Flags: review?(jonas)
Attachment #638105 - Flags: review?(jonas)
Summary: Only show prompt after 100mb of quota was reached → Only show prompt after 50mb of quota was reached

Updated

5 years ago
Attachment #638105 - Attachment is patch: true
Attachment #638105 - Flags: review?(jonas) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d295ed03d7f
Comment on attachment 638105 [details] [diff] [review]
Patch

Review of attachment 638105 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/indexedDB/test/helpers.js
@@ +64,1 @@
>    });

This was commented out for a reason.  It's causing massive orange on tinderbox.
Attachment #638105 - Flags: review-
I also had to check in this followup:

https://hg.mozilla.org/integration/mozilla-inbound/rev/6763477075a4
Jonas checked in a follow-up patch to avoid oranges, and it broke things again. (Irony++)
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8bfe5a447e7

Follow-up backed out:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3b30ca51a2a1
Looks like a8bfe5a447e7 was almost correct, you just need to make sure you call SimpleTest.finish().
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #7)
> This was commented out for a reason.  It's causing massive orange on
> tinderbox.

Somehow I missed that change. Did you look into the reason this causes problems?
OK, I've pushed a8bfe5a447e7 with SimpleTest.finish() added per comment 10. If this doesn't clear things up, I'm going to back out the entire set of patches for this bug.
https://hg.mozilla.org/integration/mozilla-inbound/rev/540cd3aabdd4
(In reply to Ryan VanderMeulen from comment #12)
> OK, I've pushed a8bfe5a447e7 with SimpleTest.finish() added per comment 10.
> If this doesn't clear things up, I'm going to back out the entire set of
> patches for this bug.
> https://hg.mozilla.org/integration/mozilla-inbound/rev/540cd3aabdd4

Looking much better on TBPL.
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=540cd3aabdd4
(In reply to ben turner [:bent] from comment #11)
> (In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #7)
> > This was commented out for a reason.  It's causing massive orange on
> > tinderbox.
> 
> Somehow I missed that change. Did you look into the reason this causes
> problems?

I haven't had time to investigate it yet.
https://hg.mozilla.org/mozilla-central/rev/2d295ed03d7f
https://hg.mozilla.org/mozilla-central/rev/6763477075a4
https://hg.mozilla.org/mozilla-central/rev/540cd3aabdd4
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
Depends on: 770085
I backed out all three changesets due to causing bug 770085. :(

https://hg.mozilla.org/integration/mozilla-inbound/rev/63f1d0471102
https://hg.mozilla.org/integration/mozilla-inbound/rev/c675f4171c3f
https://hg.mozilla.org/integration/mozilla-inbound/rev/9824d5acb894
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Sigh. B2G will need to stop setting the "indexedDB" permission for gaia apps. It will still need to set the "indexedDB-unlimited" permission.
(In reply to ben turner [:bent] from comment #17)
> Sigh. B2G will need to stop setting the "indexedDB" permission for gaia
> apps. It will still need to set the "indexedDB-unlimited" permission.

So the solution is to synchronize this landing with removing the indexedDB permission in gaia?
Created attachment 638477 [details] [diff] [review]
patch

Remove indexedDB permission for B2G
(In reply to Chris Pearce (:cpearce) from comment #16)
> I backed out all three changesets due to causing bug 770085. :(
> 
> https://hg.mozilla.org/integration/mozilla-inbound/rev/63f1d0471102
> https://hg.mozilla.org/integration/mozilla-inbound/rev/c675f4171c3f
> https://hg.mozilla.org/integration/mozilla-inbound/rev/9824d5acb894

https://hg.mozilla.org/mozilla-central/rev/63f1d0471102
https://hg.mozilla.org/mozilla-central/rev/c675f4171c3f
https://hg.mozilla.org/mozilla-central/rev/9824d5acb894
Yes, flipping this in Gaia and Gecko at the same time should fix things.
Attachment #638477 - Flags: review?(fabrice)
Attachment #638477 - Flags: review?(fabrice) → review+
(In reply to Jonas Sicking (:sicking) from comment #21)
> Yes, flipping this in Gaia and Gecko at the same time should fix things.

And we are in a situation again where we will break indexeddb because we can't land this patch at the same time in Gaia and Gecko. People are using hg-inbound, hg-mc and the github-mc gecko tree....

So the whole patch here is backed out right?
(In reply to Gregor Wagner [:gwagner] from comment #22)
> (In reply to Jonas Sicking (:sicking) from comment #21)
> > Yes, flipping this in Gaia and Gecko at the same time should fix things.
> 
> And we are in a situation again where we will break indexeddb because we
> can't land this patch at the same time in Gaia and Gecko. People are using
> hg-inbound, hg-mc and the github-mc gecko tree....
> 

Ah it shouldn't be a problem because the permission is set in gecko. It's too early for me.
https://hg.mozilla.org/integration/mozilla-inbound/rev/e7ccacd50d63
https://hg.mozilla.org/integration/mozilla-inbound/rev/0504d9475cd5
https://hg.mozilla.org/mozilla-central/rev/e7ccacd50d63
https://hg.mozilla.org/mozilla-central/rev/0504d9475cd5
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
Depends on: 786769
You need to log in before you can comment on or make changes to this bug.