75842 - crash after selecting in Bookmarks pull down menu with stacktrace in clickhold.

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P1)

Description

[hirata masakazu]

2001041204 and 041115 Mac trunk
This is a bit difficult to reproduce.
I usually have mail/news and several browsers windows open.
When I go through Bookmarks pulldown window and release click button at an item
in the submenu, Mozilla occasionally crashes with a reproducible stack strace
that starts at: nsEventStateManager::sClickHoldCallback(nsITimer*, void*)+00018.

Comment 1

[hirata masakazu]

Attachment: stack trace of the crash

Comment 2

[joki (gone)]

cvsblame attributes the Mac clickhold stuff to pink.  I'll let him take a look 
at this.

Comment 3

[Mike Pinkerton (not reading bugmail)]

i need to find a way to disable click-hold when there is a popup attribute on the 
clicked on node. That should fix this problem. Taking for 0.9.1

Comment 4

[Mike Pinkerton (not reading bugmail)]

Attachment: [patch] don't do click-hold on menubuttons or buttons with a popup

Comment 5

[Mike Pinkerton (not reading bugmail)]

needing r/sr for attached patch.

Comment 6

[hirata masakazu]

FYI: I have experienced crash with the same stacktrace right after clicking a
hyperlink in web pages. Therefore disabling click-hold for menus and buttons may
not be adequate.

Comment 7

[Mike Pinkerton (not reading bugmail)]

also added:

nsEventStateManager::~nsEventStateManager()
{
#if CLICK_HOLD_CONTEXT_MENUS
  if ( mClickHoldTimer ) {
    mClickHoldTimer->Cancel();
    mClickHoldTimer = nsnull;
  }
#endif

...

that shoudl do it. not sure how i missed this the first time.

Comment 8

[Blake Ross]

*** Bug 77772 has been marked as a duplicate of this bug. ***

Comment 9

[hirata masakazu]

Could this be included in 0.9?

Comment 10

[Madhur Bhatia]

QA contact updated

Comment 11

[Madhur Bhatia]

marking verified - checked on Mac os8.6 buildid: 2001061908