Closed Bug 758497 Opened 8 years ago Closed 8 years ago

Figure out Cursor.advance arg size

Categories

(Core :: Storage: IndexedDB, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: bent.mozilla, Assigned: khuey)

References

Details

Attachments

(1 file)

The spec says Cursor.advance is supposed to be unsigned long, but then also says that we're supposed to throw on negative numbers. Our code has PRInt32, which means we can't accept PR_UINT32_MAX like we're probably supposed to. Need to figure out what to do here.
This is now written with [EnforceRange], so I think we should punt on this until we have new bindings for IDB.
Attached patch PatchSplinter Review
Assignee: nobody → khuey
Status: NEW → ASSIGNED
Attachment #637182 - Flags: review?(bent.mozilla)
Comment on attachment 637182 [details] [diff] [review]
Patch

Review of attachment 637182 [details] [diff] [review]:
-----------------------------------------------------------------

r+ if you add a test.
Attachment #637182 - Flags: review?(bent.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/333849115ee2
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.