Closed Bug 758589 Opened 8 years ago Closed 8 years ago
"ASSERTION: Must have view manager" with moz
Request Full Screen, contenteditable, selection .to String
###!!! ASSERTION: Must have view manager: '!isSafeToFlush || mViewManager', file layout/base/nsPresShell.cpp, line 3719 Might be a regression from bug 748961, which added a Flush_Style to nsTypedSelection::ToString. These variations do *not* assert: Using a fresh selection object "" + window.getSelection(); Forcing a full layout flush document.documentElement.offsetHeight
GetPresShell use nsTypedSelection::mPresShellWeak which isn't nulled out by DisconnectFromPresShell. Maybe we should, but let's take this safe patch for now. https://tbpl.mozilla.org/?usebuildbot=1&tree=Try&rev=25c7876a569a
Attachment #627317 - Flags: review?(bugs)
BTW, is Destroy'ing the pres shell expected when entering full screen mode?
(In reply to Mats Palmgren [:mats] from comment #3) > BTW, is Destroy'ing the pres shell expected when entering full screen mode? I think so, we change the position or display of some ancestor of the content document in chrome when we go into fullscreen, so it gets reframed.
Comment on attachment 627317 [details] [diff] [review] fix This is safe.
Attachment #627317 - Flags: review?(bugs) → review+
OS: Mac OS X → All
Hardware: x86_64 → All
Target Milestone: --- → mozilla15
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/cf9f2ec36992 despite probably being harmless and just keeping bad company in that push. Something in that push caused bug 759243, which horrifies me so much I wanted to kill it with as much fire as possible.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.