"ASSERTION: Must have view manager" with mozRequestFullScreen, contenteditable, selection.toString

RESOLVED FIXED in mozilla15

Status

()

Core
Selection
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Jesse Ruderman, Assigned: mats)

Tracking

(Blocks: 1 bug, {assertion, testcase})

Trunk
mozilla15
assertion, testcase
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

5 years ago
Created attachment 627202 [details]
testcase (requires focus) (click the button)

###!!! ASSERTION: Must have view manager: '!isSafeToFlush || mViewManager', file layout/base/nsPresShell.cpp, line 3719

Might be a regression from bug 748961, which added a Flush_Style to nsTypedSelection::ToString.

These variations do *not* assert:
  Using a fresh selection object        "" + window.getSelection();
  Forcing a full layout flush           document.documentElement.offsetHeight
(Reporter)

Comment 1

5 years ago
Created attachment 627203 [details]
stack trace
(Assignee)

Updated

5 years ago
Assignee: nobody → matspal
(Assignee)

Comment 2

5 years ago
Created attachment 627317 [details] [diff] [review]
fix

GetPresShell use nsTypedSelection::mPresShellWeak which isn't nulled
out by DisconnectFromPresShell.  Maybe we should, but let's take this
safe patch for now.

https://tbpl.mozilla.org/?usebuildbot=1&tree=Try&rev=25c7876a569a
Attachment #627317 - Flags: review?(bugs)
(Assignee)

Comment 3

5 years ago
BTW, is Destroy'ing the pres shell expected when entering full screen mode?
(In reply to Mats Palmgren [:mats] from comment #3)
> BTW, is Destroy'ing the pres shell expected when entering full screen mode?

I think so, we change the position or display of some ancestor of the content document in chrome when we go into fullscreen, so it gets reframed.

Comment 5

5 years ago
Comment on attachment 627317 [details] [diff] [review]
fix

This is safe.
Attachment #627317 - Flags: review?(bugs) → review+
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/6d605438199c
OS: Mac OS X → All
Hardware: x86_64 → All
Target Milestone: --- → mozilla15
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/cf9f2ec36992 despite probably being harmless and just keeping bad company in that push. Something in that push caused bug 759243, which horrifies me so much I wanted to kill it with as much fire as possible.
(Assignee)

Comment 8

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/3a67959f7dce

Comment 9

5 years ago
https://hg.mozilla.org/mozilla-central/rev/3a67959f7dce
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.