don't include CodeResources file in builds that aren't getting signed

RESOLVED FIXED

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bhearsum, Assigned: bhearsum)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
As of bug 732176 we're shipping a Contents/_CodeSignature/CodeResources in every mac build. 
It'd be good to stop doing this for builds that don't have a MOZ_SIGN_CMD, since we know we won't be signing them.
(Assignee)

Comment 1

5 years ago
Unfortunately, we don't have any existing variables (that I can find) that will let us accomplish this....maybe we can create a new one in configure.in based on the value of MOZ_SIGN_CMD.
(Assignee)

Comment 2

5 years ago
wip on https://github.com/bhearsum/mozilla-central/tree/no-coderesources-unsigned
(Assignee)

Comment 3

5 years ago
Created attachment 627785 [details] [diff] [review]
don't include CodeResources when MOZ_SIGNING isn't set

I did my best to test this on try by adding a "export MOZ_SIGN_CMD=" at the top of the configure.in hunk. That ended up causing signing errors, because MOZ_SIGN_CMD was set during "make package" but CodeResources was missing. To me, that indicates success :).
Attachment #627785 - Flags: review?(ted.mielczarek)
(Assignee)

Comment 4

5 years ago
We need to port this to Thunderbird, too.
Blocks: 761525
Attachment #627785 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 5

5 years ago
Comment on attachment 627785 [details] [diff] [review]
don't include CodeResources when MOZ_SIGNING isn't set

http://hg.mozilla.org/mozilla-central/rev/0f2b57130b26
Attachment #627785 - Flags: checkin+
(Assignee)

Comment 6

5 years ago
Landed cleanly.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.