The default bug view has changed. See this FAQ.

Change the pause icon to a play icon in the debugger toolbar

RESOLVED FIXED in Firefox 15

Status

()

Firefox
Developer Tools: Debugger
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: rc, Assigned: rc)

Tracking

unspecified
Firefox 15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(4 attachments, 2 obsolete attachments)

(Assignee)

Description

5 years ago
The Pause icon is usually not what you're interested in. The activity we perform most-frequently is "Resuming execution" which is more of a "Play" action than "Pause".

We have options:

1. Always use a Play icon instead of Pause.
2. Switch between Play and Pause depending on state (checked would switch to Play, unchecked would be Pause).
3. Incorporate a single Play/Pause button that doesn't change. The |> button.
(Assignee)

Updated

5 years ago
Blocks: 676586
(Assignee)

Comment 1

5 years ago
Paul suggests option 1. Always use the Play icon. I'm inclined to say yes, let's do this for this release. Later on when we have the Threads panel we'll need to be able to pause workers and the pause button may make sense for that.
Created attachment 628329 [details]
Play Icon
(Assignee)

Comment 3

5 years ago
yes!
(Assignee)

Updated

5 years ago
Summary: Investigate adding a play icon to the debugger toolbar in place of pause → Change the pause icon to a play icon in the debugger toolbar
Currently there is no icon for the "play/pause" button when the script is not paused on Win7. I'm not sure if this bug is meant to add the icon there, or if this bug is supposed to change the icon that is supposed to be there.

See this screenshot for an example of what I'm talking about: 
http://screencast.com/t/jbptmYe93X
Created attachment 628675 [details] [diff] [review]
Windows fix for the pause icon

Confirmed the missing pause icon. This patch should fix it, although my Win VM will take a while to verify this.
Attachment #628675 - Flags: review?(rcampbell)
(In reply to Panos Astithas [:past] from comment #5)
> Created attachment 628675 [details] [diff] [review]
> Windows fix for the pause icon
> 
> Confirmed the missing pause icon. This patch should fix it, although my Win
> VM will take a while to verify this.

Fix verified.
(Assignee)

Comment 7

5 years ago
this isn't really the bug for that. This is about replacing the pause icons with play icons.

I'll have a patch ready (that includes windows) today.
(Assignee)

Comment 8

5 years ago
Created attachment 628907 [details] [diff] [review]
play icons

ok, here it is.

I left the pause icon in place figuring well want it again.
Assignee: nobody → rcampbell
Attachment #628675 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #628675 - Flags: review?(rcampbell)
Attachment #628907 - Flags: review?(past)
(Assignee)

Comment 9

5 years ago
Created attachment 628908 [details]
mac screenshot
(Assignee)

Comment 10

5 years ago
Created attachment 628929 [details] [diff] [review]
play icons v1
Attachment #628907 - Attachment is obsolete: true
Attachment #628929 - Flags: review?(dcamp)
Attachment #628907 - Flags: review?(past)
(Assignee)

Comment 11

5 years ago
Created attachment 628930 [details]
windows screenshot

Updated

5 years ago
Attachment #628929 - Flags: review?(dcamp) → review+
(Assignee)

Updated

5 years ago
Whiteboard: [land-in-fx-team]
(Assignee)

Comment 12

5 years ago
https://hg.mozilla.org/integration/fx-team/rev/5d7b03e92502
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
(Assignee)

Comment 13

5 years ago
https://hg.mozilla.org/mozilla-central/rev/5d7b03e92502
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 15
You need to log in before you can comment on or make changes to this bug.