Last Comment Bug 758799 - [Mac] remove mIsExpired from mozAccessible
: [Mac] remove mIsExpired from mozAccessible
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: mozilla16
Assigned To: Hubert Figuiere [:hub]
:
Mentors:
Depends on:
Blocks: osxa11y
  Show dependency treegraph
 
Reported: 2012-05-25 14:31 PDT by Hubert Figuiere [:hub]
Modified: 2012-07-06 07:50 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Check accessible expiry properly. r= (9.02 KB, patch)
2012-06-12 13:33 PDT, Hubert Figuiere [:hub]
no flags Details | Diff | Review
Check accessible expiry properly. r= (9.03 KB, patch)
2012-06-12 18:25 PDT, Hubert Figuiere [:hub]
dbolter: review+
Details | Diff | Review

Description Hubert Figuiere [:hub] 2012-05-25 14:31:42 PDT
remove mExpired from mozAccessible

See https://bugzilla.mozilla.org/show_bug.cgi?id=758304#c5
Comment 1 Hubert Figuiere [:hub] 2012-06-07 18:01:12 PDT
And at the same time check for mGeckoAccessible in the various places to avoid crash.
Comment 2 Hubert Figuiere [:hub] 2012-06-12 13:33:32 PDT
Created attachment 632388 [details] [diff] [review]
Check accessible expiry properly. r=
Comment 3 Hubert Figuiere [:hub] 2012-06-12 18:25:25 PDT
Created attachment 632489 [details] [diff] [review]
Check accessible expiry properly. r=
Comment 4 David Bolter [:davidb] 2012-06-15 10:57:05 PDT
Comment on attachment 632489 [details] [diff] [review]
Check accessible expiry properly. r=

Review of attachment 632489 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

::: accessible/src/mac/mozAccessible.mm
@@ +561,5 @@
>  }
>  
>  - (BOOL)isEnabled
>  {
> +  return mGeckoAccessible && ((mGeckoAccessible->InteractiveState() & states::UNAVAILABLE) == 0);

I would habitually enclose this in ()'s but ok. I can't recall our agreed style on this.
Comment 6 :Ehsan Akhgari (busy, don't ask for review please) 2012-07-06 07:50:35 PDT
https://hg.mozilla.org/mozilla-central/rev/91e737d544c7

Note You need to log in before you can comment on or make changes to this bug.