Closed Bug 758799 Opened 9 years ago Closed 9 years ago

[Mac] remove mIsExpired from mozAccessible

Categories

(Core :: Disability Access APIs, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: hub, Assigned: hub)

References

Details

Attachments

(1 file, 1 obsolete file)

remove mExpired from mozAccessible

See https://bugzilla.mozilla.org/show_bug.cgi?id=758304#c5
Assignee: nobody → hub
Blocks: osxa11y
Summary: [Mac] remove mExpired from mozAccessible → [Mac] remove mIsExpired from mozAccessible
And at the same time check for mGeckoAccessible in the various places to avoid crash.
Attachment #632388 - Flags: review?(surkov.alexander)
Attachment #632388 - Attachment is obsolete: true
Attachment #632388 - Flags: review?(surkov.alexander)
Attachment #632489 - Flags: review?(surkov.alexander)
Attachment #632489 - Flags: review?(surkov.alexander) → review?(dbolter)
Comment on attachment 632489 [details] [diff] [review]
Check accessible expiry properly. r=

Review of attachment 632489 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

::: accessible/src/mac/mozAccessible.mm
@@ +561,5 @@
>  }
>  
>  - (BOOL)isEnabled
>  {
> +  return mGeckoAccessible && ((mGeckoAccessible->InteractiveState() & states::UNAVAILABLE) == 0);

I would habitually enclose this in ()'s but ok. I can't recall our agreed style on this.
Attachment #632489 - Flags: review?(dbolter) → review+
https://hg.mozilla.org/mozilla-central/rev/91e737d544c7
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.