[Mac] remove mIsExpired from mozAccessible

RESOLVED FIXED in mozilla16

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: hub, Assigned: hub)

Tracking

(Blocks: 1 bug)

Trunk
mozilla16
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
remove mExpired from mozAccessible

See https://bugzilla.mozilla.org/show_bug.cgi?id=758304#c5
(Assignee)

Updated

5 years ago
Assignee: nobody → hub
(Assignee)

Updated

5 years ago
Blocks: 342989
Summary: [Mac] remove mExpired from mozAccessible → [Mac] remove mIsExpired from mozAccessible
(Assignee)

Comment 1

5 years ago
And at the same time check for mGeckoAccessible in the various places to avoid crash.
(Assignee)

Comment 2

5 years ago
Created attachment 632388 [details] [diff] [review]
Check accessible expiry properly. r=
(Assignee)

Updated

5 years ago
Attachment #632388 - Flags: review?(surkov.alexander)
(Assignee)

Comment 3

5 years ago
Created attachment 632489 [details] [diff] [review]
Check accessible expiry properly. r=
(Assignee)

Updated

5 years ago
Attachment #632388 - Attachment is obsolete: true
Attachment #632388 - Flags: review?(surkov.alexander)
(Assignee)

Updated

5 years ago
Attachment #632489 - Flags: review?(surkov.alexander)
(Assignee)

Updated

5 years ago
Attachment #632489 - Flags: review?(surkov.alexander) → review?(dbolter)
Comment on attachment 632489 [details] [diff] [review]
Check accessible expiry properly. r=

Review of attachment 632489 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

::: accessible/src/mac/mozAccessible.mm
@@ +561,5 @@
>  }
>  
>  - (BOOL)isEnabled
>  {
> +  return mGeckoAccessible && ((mGeckoAccessible->InteractiveState() & states::UNAVAILABLE) == 0);

I would habitually enclose this in ()'s but ok. I can't recall our agreed style on this.
Attachment #632489 - Flags: review?(dbolter) → review+
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/91e737d544c7
https://hg.mozilla.org/mozilla-central/rev/91e737d544c7
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.