Last Comment Bug 758304 - [Mac] crash in nsAccUtils::IsTextInterfaceSupportCorrect()
: [Mac] crash in nsAccUtils::IsTextInterfaceSupportCorrect()
Status: RESOLVED FIXED
: crash
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: Trunk
: x86 Mac OS X
: -- critical (vote)
: mozilla15
Assigned To: Hubert Figuiere [:hub]
:
Mentors:
Depends on:
Blocks: 750612
  Show dependency treegraph
 
Reported: 2012-05-24 11:29 PDT by Hubert Figuiere [:hub]
Modified: 2012-05-26 23:26 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Check for expired. Make sure expire do the right thing. r= (1.47 KB, patch)
2012-05-24 11:31 PDT, Hubert Figuiere [:hub]
tbsaunde+mozbugs: review+
Details | Diff | Review

Description Hubert Figuiere [:hub] 2012-05-24 11:29:55 PDT
This crash occur since changeset 9b7bea577a43 for bug 750191. It is caused by the use of a deleted nsAccessible*, and only occur in DEBUG.

Patch coming.
Comment 1 Hubert Figuiere [:hub] 2012-05-24 11:31:43 PDT
Created attachment 626895 [details] [diff] [review]
Check for expired. Make sure expire do the right thing. r=
Comment 2 Hubert Figuiere [:hub] 2012-05-24 11:33:50 PDT
setting block as it is triggered by testing bug 750612
Comment 3 Trevor Saunders (:tbsaunde) 2012-05-24 11:40:15 PDT
Comment on attachment 626895 [details] [diff] [review]
Check for expired. Make sure expire do the right thing. r=

> #ifdef DEBUG
>   NS_ASSERTION(nsAccUtils::IsTextInterfaceSupportCorrect(mGeckoAccessible),
>                "Does not support nsIAccessibleText when it should");
> #endif

btw you could remove the ifdef since sserts are a nop in opt builds
Comment 5 alexander :surkov 2012-05-25 00:32:29 PDT
Comment on attachment 626895 [details] [diff] [review]
Check for expired. Make sure expire do the right thing. r=

Review of attachment 626895 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/mac/mozAccessible.mm
@@ +632,2 @@
>    mIsExpired = YES;
> +  mGeckoAccessible = nsnull;

since you null out mGeckoAccessible then you don't need mIsExpired member. Please file follow up bug on this.
Comment 6 Ed Morley [:emorley] 2012-05-25 08:24:18 PDT
https://hg.mozilla.org/mozilla-central/rev/43ee60cc0ee1
Comment 7 Hubert Figuiere [:hub] 2012-05-25 14:32:41 PDT
> since you null out mGeckoAccessible then you don't need mIsExpired member.
> Please file follow up bug on this.

Filed as bug 758799

Note You need to log in before you can comment on or make changes to this bug.