Closed Bug 758882 Opened 8 years ago Closed 8 years ago

Populate treestatus.mozilla.org with active trees & default messages

Categories

(Release Engineering :: Applications: TreeStatus, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

References

Details

[Not really the correct component, but since Tree Status is using Github for issue tracking (and this blocks bug 756027), I wanted something actually in Bugzilla]

Before we can do bug 756027, we need all the active trees added, along with default "see tree rules" type messages.

Looking at the list at http://tinderbox.mozilla.org/showbuilds.cgi and also bug 625979 comment 2, there are a lot of old trees in there, that I would *really* like to not have to add to the new site, so we don't spend ages scrolling up and down lists of ancient trees.

However, the hook in bug 756027 (at least for the moment) fails open. So if we don't add old repos such as tracemonkey to treestatus.mozilla.org, people are going to be able to push to them when they couldn't before.

Options:

1) Accept that old repos can be pushed to and that it's not a problem since they aren't being used anyway.

2) Add a way of marking trees on treestatus.mozilla.org as hidden/not shown by default? 

3) Just delete these old repos entirely (where they have been merged into m-c already and no longer used) and avoid the problem altogether.

Few other things:

* Do all of the trees listed at http://tinderbox.mozilla.org/showbuilds.cgi even have the tree hook enabled? (bug 754132 comment 2 says that it's set in $repo/.hg/hgrc on the server, so I don't know of any way of checking remotely). If not, then we at least won't be any worse off for those particular repos when bug 756027 lands. Similarly, many have a blank tree status already (eg http://tinderbox.mozilla.org/admintree.cgi?tree=XULRunner) that don't need to be added to treestatus either.

* I'm presuming SeaMonkey/Thunderbird use other hooks (eg http://hg.mozilla.org/hgcustom/hghooks/file/tip/mozhghooks/treeclosure_comm_central.py), so can be ignored for now and dealt with in a followup?

Can't wait to get rid of tinderbox (for Firefox related trees at least)... we're so close I can taste it! \o/
Assignee: nobody → bmo
Status: NEW → ASSIGNED
Depends on: 758994
(In reply to Ed Morley [:edmorley] from comment #0)
> * I'm presuming SeaMonkey/Thunderbird use other hooks (eg
> http://hg.mozilla.org/hgcustom/hghooks/file/tip/mozhghooks/
> treeclosure_comm_central.py), so can be ignored for now and dealt with in a
> followup?

Thunderbird will be using treestatus.mozilla.org, but via that hook - I've not written the code yet (which could get interesting now I think about it!), but will get to that today.
I've sorted the results from bug 758994...

The following repos have the standard treeclosure hook enabled:

integration/mozilla-inbound/
mozilla-central/
projects/2007-configure-rewrite/
projects/addonsmgr/
projects/electrolysis/
projects/firefox-lorentz/
projects/kraken/
projects/mccoy/
projects/places/
projects/webcl/
releases/mobile-1.1/
releases/mozilla-1.9.1/
releases/mozilla-1.9.2/
releases/mozilla-2.0/
releases/mozilla-aurora/
releases/mozilla-beta/
releases/mozilla-esr10/
releases/mozilla-release/
services/services-central/
tracemonkey/
try/

treeclosure_comm_central.py:

comm-central/
releases/comm-1.9.1/
releases/comm-1.9.2/
releases/comm-2.0/
releases/comm-aurora/
releases/comm-beta/
releases/comm-esr10/
releases/comm-miramar/
releases/comm-release/
try-comm-central/

These ones probably should have a hook, but we'll come back to these later (since the current hook has to know about a tree first anyway, so we can't enable the hook in advance of bug 756027 landing anyway):

integration/fx-team/
projects/accessibility/
projects/alder/
projects/ash/
projects/birch/
projects/build-system/
projects/cedar/
projects/devtools/
projects/elm/
projects/graphics/
projects/holly/
projects/ionmonkey/
projects/jaegermonkey/
projects/larch/
projects/maple/
projects/oak/
projects/pine/
projects/profiling/
Narrowing the list down to repos that were recognised by the old hook and also have had commits in the last 6 months, gives:

integration/mozilla-inbound/
mozilla-central/
releases/mozilla-1.9.2/
releases/mozilla-aurora/
releases/mozilla-beta/
releases/mozilla-esr10/
releases/mozilla-release/
services/services-central/
try/
try-comm-central/ (was mistakenly under the c-c hook above)

I've added all of the above to treestatus prod (and have deleted the incorrectly named 'Try' & 'Firefox').

I've set OPEN/APPROVAL REQUIRED appropriately and set the tree status messages to match those currently on the tinderbox status pages.

For treeclosure_comm_central.py, Mark has already added comm-central-thunderbird (and related variants) & the others can be done if/when they switch to treestatus.m.o.

Until such point where the others switch, or we fix the closure hook on things like fx-team (which will have to wait until bug 756027 lands anyway), I believe we're all done here :-)
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
1.9.2 can go to /dev/null. Bug 753178 removed all buildbot support for it.
Oh yeah! \o/ Bug 756724 isn't yet on TBPL prod so I keep on forgetting we've already landed the removal of of 3.6 from buildbot-configs :-)

1.9.2 removed. 

Btw, for anyone doing this themselves later, the easiest way I've found to do this so far (until https://github.com/catlee/treestatus/issues/7), is to:
1) Install an add-on like Tamper Data (https://addons.mozilla.org/en-US/firefox/addon/tamper-data/)
2) Go to https://treestatus.mozilla.org/<tree-name>
3) Activate tamper mode
4) Press submit query on the tree page with the reason filled out
5) On the alert, choose tamper
6) Remove the status element, add "_method=DELETE"
7) Submit
Component: Tinderboxpushlog → Tree Status
Product: Webtools → Tree Management
Product: Tree Management → Release Engineering
You need to log in before you can comment on or make changes to this bug.