758888 - Make mercurial closure hooks fail closed once treestatus.mozilla.org proven reliable

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Ed Morley [:emorley]]

(Chris AtLee [:catlee] from bug 754132 comment #4)
> > If we turn treestatus into a production service, we should consider making
> > this fail closed. treestatus seems simple enough that we could make that
> > work.
> 
> Let's deploy with fail open first and see how it handles things.

Once bug 754132 has been resolved and we're happy with treestatus.mozilla.org, we should switch to failing closed rather than open - especially given that people can always override the hook using CLOSED TREE anyway, were there to be issues with treestatus.

This will also alleviate the "we want to keep ancient trees closed, but don't want them cluttering up the treestatus UI" problem of bug 758882 comment 0.

Comment 1

[Ed Morley [:emorley]]

We should do this.

People managed to land on aurora today due to treestatus HTTP 500 errors :-(

Comment 2

[Ed Morley [:emorley]]

Attachment: Patch v1

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 692978 [details] [diff] [review]
Patch v1

Review of attachment 692978 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozhghooks/treeclosure.py
@@ +52,5 @@
>      except (ValueError, IOError), (err):
>          # fail open. no sense making hg unavailable
>          # if treestatus is down
>          print "Error: %s" % err, url
> +        return 1

Please make the error message more verbose while you're here, so that people have an understanding of why their push is failing. Also, this print statement is written oddly. It's actually doing print ("Error: %s" % err), url. Maybe tweak that to be less confusing while you're at it?

Comment 4

[Ed Morley [:emorley]]

Attachment: Patch v2

I know r+ already, but a few more changes, just wanted to make sure you're ok with making the except a bit more complex.

Comment 5

[Ed Morley [:emorley]]

Cheers :-)

https://hg.mozilla.org/hgcustom/hghooks/rev/4a9228a54a7d

Comment 6

[Gregory Szorc [:gps]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/2bd6696e11b5