Closed Bug 759017 Opened 9 years ago Closed 9 years ago

whitelisted key events does not contain correct keyCode information

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla15

People

(Reporter: timdream, Assigned: vingtetun)

References

(Depends on 1 open bug)

Details

Attachments

(2 files)

+++ This bug was initially created as a clone of Bug #757486 +++

STR in Gaia:

1. replace apps/system/index.html with https://gist.github.com/2817145
2. in Gecko, invalid forwardKeyToHomescreen in b2g/chrome/content/shell.js (add |return;| at line 194)
3. Tap on the black space, allowing the iframe to gain focus
4. Press some keys

Expected:

* Getting keyCode in dump()

Actual result:

* Getting keyCode = 0
Blocks: 757486
No longer depends on: 757486
Attached patch PatchSplinter Review
That's a small typo.
Assignee: nobody → 21
Status: NEW → ASSIGNED
Attachment #628714 - Flags: review?(mounir)
This should be tested, if we can...
Comment on attachment 628714 [details] [diff] [review]
Patch

Review of attachment 628714 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for fixing that :)
Attachment #628714 - Flags: review?(mounir) → review+
(In reply to Justin Lebar [:jlebar] from comment #2)
> This should be tested, if we can...

Damn... this is actually tested but the test has an error :-/
Attached patch Test fixSplinter Review
Two stupid mistakes that happen to be in the code and the test checking the code... that's unfortunate :-/
Attachment #628725 - Flags: review?(21)
Attachment #628725 - Flags: review?(21) → review+
Flags: in-testsuite+
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/f16847bdf086
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
No longer blocks: 761093
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.