Last Comment Bug 759017 - whitelisted key events does not contain correct keyCode information
: whitelisted key events does not contain correct keyCode information
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla15
Assigned To: Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)
:
: Andrew Overholt [:overholt]
Mentors:
Depends on: 757764
Blocks: 755648 757486 761060 761067
  Show dependency treegraph
 
Reported: 2012-05-27 21:13 PDT by Tim Guan-tin Chien [:timdream] (please needinfo)
Modified: 2012-06-06 02:07 PDT (History)
5 users (show)
mounir: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (864 bytes, patch)
2012-05-31 07:13 PDT, Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)
mounir: review+
Details | Diff | Splinter Review
Test fix (1.08 KB, patch)
2012-05-31 07:28 PDT, Mounir Lamouri (:mounir)
justin.lebar+bug: review+
Details | Diff | Splinter Review

Description Tim Guan-tin Chien [:timdream] (please needinfo) 2012-05-27 21:13:50 PDT
+++ This bug was initially created as a clone of Bug #757486 +++

STR in Gaia:

1. replace apps/system/index.html with https://gist.github.com/2817145
2. in Gecko, invalid forwardKeyToHomescreen in b2g/chrome/content/shell.js (add |return;| at line 194)
3. Tap on the black space, allowing the iframe to gain focus
4. Press some keys

Expected:

* Getting keyCode in dump()

Actual result:

* Getting keyCode = 0
Comment 1 Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please) 2012-05-31 07:13:10 PDT
Created attachment 628714 [details] [diff] [review]
Patch

That's a small typo.
Comment 2 Justin Lebar (not reading bugmail) 2012-05-31 07:18:14 PDT
This should be tested, if we can...
Comment 3 Mounir Lamouri (:mounir) 2012-05-31 07:18:28 PDT
Comment on attachment 628714 [details] [diff] [review]
Patch

Review of attachment 628714 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for fixing that :)
Comment 4 Mounir Lamouri (:mounir) 2012-05-31 07:26:47 PDT
(In reply to Justin Lebar [:jlebar] from comment #2)
> This should be tested, if we can...

Damn... this is actually tested but the test has an error :-/
Comment 5 Mounir Lamouri (:mounir) 2012-05-31 07:28:47 PDT
Created attachment 628725 [details] [diff] [review]
Test fix

Two stupid mistakes that happen to be in the code and the test checking the code... that's unfortunate :-/
Comment 6 Ed Morley [:emorley] 2012-06-01 08:42:15 PDT
https://hg.mozilla.org/mozilla-central/rev/f16847bdf086
Comment 7 Ed Morley [:emorley] 2012-06-01 08:42:30 PDT
And:
https://hg.mozilla.org/mozilla-central/rev/a35f9c1fef54

Note You need to log in before you can comment on or make changes to this bug.