759017 - whitelisted key events does not contain correct keyCode information

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

+++ This bug was initially created as a clone of Bug #757486 +++

STR in Gaia:

1. replace apps/system/index.html with https://gist.github.com/2817145
2. in Gecko, invalid forwardKeyToHomescreen in b2g/chrome/content/shell.js (add |return;| at line 194)
3. Tap on the black space, allowing the iframe to gain focus
4. Press some keys

Expected:

* Getting keyCode in dump()

Actual result:

* Getting keyCode = 0

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

That's a small typo.

Comment 2

[Justin Lebar (not reading bugmail)]

This should be tested, if we can...

Comment 3

[Mounir Lamouri (:mounir)]

Comment on attachment 628714 [details] [diff] [review]
Patch

Review of attachment 628714 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for fixing that :)

Comment 4

[Mounir Lamouri (:mounir)]

(In reply to Justin Lebar [:jlebar] from comment #2)
> This should be tested, if we can...

Damn... this is actually tested but the test has an error :-/

Comment 5

[Mounir Lamouri (:mounir)]

Attachment: Test fix

Two stupid mistakes that happen to be in the code and the test checking the code... that's unfortunate :-/

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f16847bdf086

Comment 7

[Ed Morley [:emorley]]

And:
https://hg.mozilla.org/mozilla-central/rev/a35f9c1fef54