761060 - Sometimes key events is still trapped in frames and never received by the parent frame

Status: RESOLVED INVALID

(Firefox OS Graveyard :: General, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

With bug 757486 landed and bug 755648 pending, we now rely on <iframe mozbrowser> to forward keys to the parent frame.

However, keys from <iframe> without mozbrowser is still trapped. For the current Gaia, this includes, at least,

A) View source panel
B) tests in UI tests

Other third-party apps will hit this bug if they had ever include an iframe, e.g., a like button.

We need to get these key events to the system app.

STR:

1) In Gaia, press the Menu key to get View Source panel
2) Interact with the panel by panning the source code, have the source code panel iframe gaining focus
3) Try to leave the View Source view by pressing the menu button again, or try to adjust the volume

Expected:

* Menu button and Volume buttons should work; view source should hide and volume indication should appear.

Actual:

* They don't. The key event is never duplicated to the system app, thus never go beyond the View Source panel.

Comment 1

[Mounir Lamouri (:mounir)]

This is a use case Vivien and I never talked about... I guess we should re-think that.

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Doesn't happen anymore as we have changed the way hardware keys are handled. But we need to be careful if we are ever going to send key events as-is to child frames on B2G in the future.