759085 - Login manager doorhangers are not dismissed when loading a new page

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Paul Feher]

Attachment: Screenshot

Nightly Fennec 15.0a1 (2012-05-27)
Aurora Fennec 14.0a2 (2012-05-27)
Device: HTC Desire Z 
OS: Android 2.3.3

Steps to reproduce:
1. Load http://mlogin.yahoo.com.
2. Enter data in user and password fields for the doorhanger to appear.
3. Load another page (Ex about:firefox) without dismissing the doorhanger.

Expected:
After step 3 the the page entered should be loaded completely without the doorhanger to appear. 

Actual:
The doorhanger is still present after loading the new page.

NOTE:Please see the attached screenshot and log file.

Comment 1

[Paul Feher]

Attachment: Log file

Comment 2

[Aaron Train [:aaronmt]]

This might be by design? CC'ing Margaret. What does desktop Firefox do?

Comment 3

[Paul Feher]

On Firefox desktop the notification is dismissed when loading a new page.

Comment 4

[:Margaret Leibovic]

This is probably because of the timeout we have set on the login manager doorhanger. We set that because we want the notification to hang around through the authentication redirect dance that websites do. This may be better after I land bug 718705 later today.

Comment 5

[Paul Feher]

The issue is also reproducible on:
Firefox Mobile Native 15.0b2 build1 (2012-07-24)
Device: HTC Desire Z
OS: Android 2.3.3

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

We do check to see if we should close doorhangers for new pageloads here:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/DoorHangerPopup.java#106

Which asks the doorhanger if we can remove it:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/DoorHangerPopup.java#195

But the doorhanger settings can stop us from removing it:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/DoorHanger.java#171

And we use a 10 sec timeout for login prompts:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/components/LoginManagerPrompter.js#163

Does this problem happen if we wait >10 secs before opening a new page? If so, maybe we could consider reducing the timeout.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

... if not, ...

Comment 8

[:Margaret Leibovic]

(In reply to Mark Finkle (:mfinkle) from comment #6)

> Does this problem happen if we wait >10 secs before opening a new page? If
> so, maybe we could consider reducing the timeout.

If not, I think this just just be a WONTFIX, since reducing or getting rid of the timeout would mean the doorhanger would disappear on sites that do a redirect dance for authentication. We had this conversation for desktop doorhangers, see bug 595178 and bug 595175.

Comment 9

[Paul Feher]

The issue is not reproducible if we wait more then 10 sec. So I guess this will be a WONTFIX then.

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Paul Feher from comment #9)
> The issue is not reproducible if we wait more then 10 sec. So I guess this
> will be a WONTFIX then.

Yes. If we get more reports from users, we can look at tweaking the timeout.